Skip to content
This repository was archived by the owner on Feb 6, 2026. It is now read-only.

feat(ci): enable release and debug builds#3498

Merged
si-bors-ng[bot] merged 1 commit intomainfrom
adamhjk/release-mode
Apr 3, 2024
Merged

feat(ci): enable release and debug builds#3498
si-bors-ng[bot] merged 1 commit intomainfrom
adamhjk/release-mode

Conversation

@adamhjk
Copy link
Copy Markdown
Contributor

@adamhjk adamhjk commented Apr 2, 2024

This PR enables release and debug builds for buck2. By default, we will always do debug builds (or, more accurately, whatever the rustc compiler thinks the defaults should be).

If you want to build for release or debug explicitly, you can do that with:

$ buck2 build @//mode/release //bin/sdf:sdf

And the result will be compiled with release optimizations. You can also use @//mode/debug if you want. Those files are just ways of DRY-ing up the configuration options - you could also pass them directly on the command line.

We can add as many configuration options as we want, and as many toolchain configurations as we want, by extending the options in the //config tree, adding a new toolchain statement, and extending the select statement for the :rust alias.

@adamhjk adamhjk force-pushed the adamhjk/release-mode branch from 3917006 to cbc8842 Compare April 2, 2024 21:07
@stack72
Copy link
Copy Markdown
Contributor

stack72 commented Apr 3, 2024

bors merge

si-bors-ng Bot added a commit that referenced this pull request Apr 3, 2024
3498: feat(ci): enable release and debug builds r=stack72 a=adamhjk

This PR enables release and debug builds for buck2. By default, we will always do debug builds (or, more accurately, whatever the rustc compiler thinks the defaults should be).

If you want to build for release or debug explicitly, you can do that with:

```
$ buck2 build `@//mode/release` //bin/sdf:sdf
```

And the result will be compiled with release optimizations. You can also use ``@//mode/debug`` if you want. Those files are just ways of DRY-ing up the configuration options - you could also pass them directly on the command line.

We can add as many configuration options as we want, and as many toolchain configurations as we want, by extending the options in the `//config` tree, adding a new toolchain statement, and extending the select statement for the `:rust` alias.

<img src="https://media1.giphy.com/media/MFg6kb46z2tNOEIBox/giphy.gif"/>

Co-authored-by: Adam Jacob <adam@systeminit.com>
@si-bors-ng
Copy link
Copy Markdown
Contributor

si-bors-ng Bot commented Apr 3, 2024

Build failed:

This PR enables release and debug builds for buck2. By default, we will
always do debug builds (or, more accurately, whatever the rustc compiler
thinks the defaults should be).

If you want to build for release or debug explicitly, you can do that
with:

```
$ buck2 build @//mode/release //bin/sdf:sdf
```

And the result will be compiled with release optimizations. You can also
use `@//mode/debug` if you want. Those files are just ways of DRY-ing up
the configuration options - you could also pass them directly on the
command line.

We can add as many configuration options as we want, and as many
toolchain configurations as we want, by extending the options in the
`//config` tree, adding a new toolchain statement, and extending the
select statement for the `:rust` alias.
@adamhjk adamhjk force-pushed the adamhjk/release-mode branch from cbc8842 to 22e0fc5 Compare April 3, 2024 18:20
@adamhjk
Copy link
Copy Markdown
Contributor Author

adamhjk commented Apr 3, 2024

bors merge

@si-bors-ng
Copy link
Copy Markdown
Contributor

si-bors-ng Bot commented Apr 3, 2024

Build succeeded:

@si-bors-ng si-bors-ng Bot merged commit 7886e40 into main Apr 3, 2024
@si-bors-ng si-bors-ng Bot deleted the adamhjk/release-mode branch April 3, 2024 18:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants