This repository was archived by the owner on Feb 6, 2026. It is now read-only.
fix(web) - newhotness emitters cleanup#8318
Merged
wendybujalski merged 1 commit intomainfrom Jan 21, 2026
Merged
Conversation
wendybujalski
temporarily deployed
to
build-only
GitHub Actions
Inactive
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.Scanned FilesNone |
jobelenus
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How does this PR change the system?
This PR cleans up all previous usage of
addEventListenerinnewhotnessthat should be replaced with the more efficient pattern using theemitters.tslogic composable.Going forward, we want to avoid adding any usage of
addEventListenerto individual Vue components, instead using the existing tools inemitters.tsor adding a new emitter to that file when necessary.Out of Scope:
Cases of
addEventListeneroutside ofnewhotnessare not changed. We may eventually want to move theemitters.tslogic composable to be part of thevue-libHow was it tested?
Manual testing confirms that all cases function the same after these changes.
Does it require a docs change?
No
In short: 🔗