fix: correct YAML structure examples in skill documentation#108
Merged
github-actions[bot] merged 1 commit intomainfrom Feb 2, 2026
Merged
fix: correct YAML structure examples in skill documentation#108github-actions[bot] merged 1 commit intomainfrom
github-actions[bot] merged 1 commit intomainfrom
Conversation
- Fix model input YAML examples in swamp-model skill to match actual implementation - Fix workflow YAML example in swamp-workflow skill to match actual implementation - Update job dependency syntax from deprecated `needs` to `dependsOn` with trigger conditions ## Details The skill documentation examples were using a Kubernetes-style manifest structure with `apiVersion`, `kind`, and `metadata` fields that don't exist in the actual implementation. The correct structure uses flat top-level fields (`id`, `name`, `version`, `tags`, `attributes` for models; `id`, `name`, `description`, `version`, `jobs` for workflows). ## Test plan - [ ] Review updated examples match actual YAML files created by `swamp model create` and `swamp workflow create` - [ ] Verify examples are valid according to their respective schemas
Contributor
|
this is hilarious |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
✅ APPROVED - No blocking issues found.
This PR correctly fixes the YAML structure examples in the skill documentation to match the actual implementation.
Verified Changes
1. Model Input Structure (swamp-model/SKILL.md)
- Removed incorrect Kubernetes-style structure (
apiVersion,kind,metadata) - Updated to correct flat structure (
id,name,version,tags,attributes) - ✅ Verified against
ModelInputDataSchemainsrc/domain/models/model_input.ts
2. Workflow Structure (swamp-workflow/SKILL.md)
- Added
descriptionfield to workflow example - Updated
needs: [build]to properdependsOnsyntax with trigger conditions - ✅ Verified against
TriggerConditionSchemainsrc/domain/workflows/trigger_condition.ts - ✅ Matches usage pattern in
integration/workflow_test.ts
Review Checklist
- Documentation matches actual implementation
- No code changes requiring tests
- No security concerns
- Follows project conventions
Minor Suggestion (non-blocking)
The file path comments were updated from inputs/swamp/echo/my-echo.yaml to .data/inputs/swamp/echo/<uuid>.yaml, which accurately reflects the actual storage location. Good attention to detail!
keeb
added a commit
that referenced
this pull request
Apr 14, 2026
Interactive `swamp data gc` silently skipped version-count garbage collection when no lifetime-expired data existed, and `--dry-run` under- reported the same work. Both ran correctly only via `--force` or `--json`. Add a `dryRun` option to `collectGarbage` so the repository can compute would-be counts without deleting, and expose it through a new `previewVersionGarbage` service method. Extend `DataGcPreview` with a `versionGcItems` field, widen the CLI early-return to consider both categories, and render the new category in log and json preview output. Also consolidate the duplicated `parseDuration` helper into `src/domain/data/duration.ts`, shared by the lifecycle service and the unified data repository. Closes #108 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needstodependsOnwith trigger conditionsDetails
The skill documentation examples were using a Kubernetes-style manifest structure with
apiVersion,kind, andmetadatafieldsthat don't exist in the actual implementation. The correct structure uses flat top-level fields (
id,name,version,tags,attributesfor models;id,name,description,version,jobsfor workflows).Test plan
swamp model createandswamp workflow create