Skip to content

fix: improve issue-lifecycle skill resumption and close-out guidance#1152

Merged
stack72 merged 1 commit intomainfrom
worktree-42
Apr 9, 2026
Merged

fix: improve issue-lifecycle skill resumption and close-out guidance#1152
stack72 merged 1 commit intomainfrom
worktree-42

Conversation

@stack72
Copy link
Copy Markdown
Contributor

@stack72 stack72 commented Apr 9, 2026

Summary

Fixes #42. Three documentation improvements to the issue-lifecycle skill:

  • Fix resume command: Replace swamp model get (returns model definition) with swamp data get issue-<N> state-main --json (returns current phase), and add a phase-to-action reference table
  • Add in-flight guard: New "Before You Start" section in references/triage.md checks if the issue is already past triage before allowing start — prevents agents from accidentally resetting progress
  • Add close-out workflow: New "Closing Out a Shipped Issue" section documents how to mark a shipped issue as done (link_prcomplete)
  • Add start safety warning: Blockquote in triage.md clarifying that start unconditionally resets phase to triaging

Test Plan

  • deno fmt --check passes
  • deno lint passes
  • deno run test passes (4236 tests)
  • SKILL.md stays under 500 lines (168 lines)
  • Verified phase-to-action table matches TRANSITIONS in extensions/models/_lib/schemas.ts

🤖 Generated with Claude Code

…42)

Fix wrong resume command (swamp model get → swamp data get), add start
safety warning, add in-flight guard in triage.md, and add close-out
workflow section.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Blocking Issues

None.

Suggestions

None — this is a clean documentation improvement.

Verification notes:

  • Phase-to-action table matches the Phase enum and TRANSITIONS constant in extensions/models/_lib/schemas.ts (all 7 resumable phases covered; created correctly omitted since it's the pre-start state handled by the triage guard)
  • The start reset warning is accurate: TRANSITIONS.start accepts all phases as source, confirming unconditional reset behavior
  • The link_prcomplete close-out workflow follows valid transitions (link_pr accepts implementing/pr_open; complete accepts implementing/pr_open)
  • Corrected resume command (swamp data get vs swamp model get) returns actual phase data instead of model definition
  • SKILL.md stays well under 500-line limit (~169 lines)
  • No code changes, no test impact

@stack72 stack72 merged commit 6015415 into main Apr 9, 2026
10 checks passed
@stack72 stack72 deleted the worktree-42 branch April 9, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant