fix: improve issue-lifecycle skill resumption and close-out guidance#1152
Merged
fix: improve issue-lifecycle skill resumption and close-out guidance#1152
Conversation
…42) Fix wrong resume command (swamp model get → swamp data get), add start safety warning, add in-flight guard in triage.md, and add close-out workflow section. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
Blocking Issues
None.
Suggestions
None — this is a clean documentation improvement.
Verification notes:
- Phase-to-action table matches the
Phaseenum andTRANSITIONSconstant inextensions/models/_lib/schemas.ts(all 7 resumable phases covered;createdcorrectly omitted since it's the pre-startstate handled by the triage guard) - The
startreset warning is accurate:TRANSITIONS.startaccepts all phases as source, confirming unconditional reset behavior - The
link_pr→completeclose-out workflow follows valid transitions (link_pracceptsimplementing/pr_open;completeacceptsimplementing/pr_open) - Corrected resume command (
swamp data getvsswamp model get) returns actual phase data instead of model definition - SKILL.md stays well under 500-line limit (~169 lines)
- No code changes, no test impact
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #42. Three documentation improvements to the issue-lifecycle skill:
swamp model get(returns model definition) withswamp data get issue-<N> state-main --json(returns current phase), and add a phase-to-action reference tablereferences/triage.mdchecks if the issue is already past triage before allowingstart— prevents agents from accidentally resetting progresslink_pr→complete)startsafety warning: Blockquote in triage.md clarifying thatstartunconditionally resets phase totriagingTest Plan
deno fmt --checkpassesdeno lintpassesdeno run testpasses (4236 tests)TRANSITIONSinextensions/models/_lib/schemas.ts🤖 Generated with Claude Code