chore: Bump evals gha to use latest version of an action#1160
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
CI Security Review
Critical / High
None.
Medium
- Pre-existing —
.github/workflows/multi-model-eval.yml:36:github.event.inputs.modelsis directly interpolated in arun:block (MODELS="${{ github.event.inputs.models || 'all' }}"). While mitigated byworkflow_dispatchrequiring repo write access, best practice is to pass it via an environment variable to prevent expression injection. Not introduced by this PR.
Low
None.
Verdict
PASS — The changes are security-neutral: bumping actions/upload-artifact from v4 to v6 (GitHub-owned, tag pin acceptable) and reducing artifact retention from 30 to 14 days. No new security issues introduced.
There was a problem hiding this comment.
Code Review
Blocking Issues
None.
Suggestions
actions/download-artifact@v4on line 92 could also be bumped — while upload-artifact v6 uses the same artifact backend as v4 (the v6 bump is a Node.js 24 runtime update),download-artifactis now at v8. Bumping it in a follow-up would keep versions consistent and ensure you're on a supported Node.js runtime for both actions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.