Merged
Conversation
cel-js 7.6.0 introduced an AST refactor (split stable AST fields from mutable metadata, structured diagnostics, eval hot-path rewrite). The swamp AST walker in src/domain/data/query_predicate.ts and the ParseResult-as-callable cast in src/domain/data/data_query_service.ts are the high-risk consumers; both verified intact via the full unit suite (5522/5522) and the swamp-uat CLI suite (398/398).
There was a problem hiding this comment.
Code Review
Clean dependency bump — only deno.json and deno.lock touched, version pin updated from 7.5.1 to 7.6.1 with matching integrity hash.
Blocking Issues
None.
Suggestions
None. The PR body does an excellent job documenting the high-risk consumers (query_predicate.ts AST walker, data_query_service.ts ParseResult cast, cel_evaluator.ts error handling) and verifying them against the full test suite and UAT. Well done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
@marcbachmann/cel-jsfrom 7.5.1 to 7.6.1 (path: 7.5.2 → 7.5.3 → 7.6.0 → 7.6.1).The notable release on this path is 7.6.0, which refactored the AST (split stable AST fields from mutable metadata, added stable source ranges, structured diagnostics, eval hot-path rewrite). Per repo memory, CEL is critical to swamp and must never regress, so the bump was verified empirically rather than just trusting changelogs.
High-risk consumers (verified intact)
src/domain/data/query_predicate.ts— walks the parsed AST byop/argsshape across 12 op codes (id,.,.?,[],[?],call,rcall,?:,!_,-_,list,map,value).src/domain/data/data_query_service.ts:173— castsqueryEnv.parse(options.select)directly to a callable; line 193 invokesparsed(record)for filter predicates.src/infrastructure/cel/cel_evaluator.ts— error catches by class (InvalidExpressionError); Promise-leak detection on syncevaluate().Unrelated 7.5.x fixes that come along
uint(int)return type fix; newstring(uint)(we don't exercise these).Test Plan
deno check— passdeno lint— passdeno fmt --check— passdeno run test— 5522 passed, 0 faileddeno run compile— binary builtuat:cliagainst new binary — 398 passed, 0 failedThe history opt-out path (
isLatest/versiontriggering implicit&& isLatest == trueinjection) is covered bydata_query_service_test.tsand exercised in UAT — both green, confirmingcollectRootIdentifiersstill extracts root identifiers correctly under the new AST shape.