feat: Add telemetryDisabled config to .swamp.yaml

[keeb]

Summary

• Add telemetryDisabled?: boolean to RepoMarkerData so users can persistently opt out of telemetry via .swamp.yaml instead of passing --no-telemetry on every invocation
• Add isTelemetryDisabledByConfig() helper in src/cli/mod.ts and check it in initTelemetryService() before creating any telemetry infrastructure
• Add Telemetry section to README.md documenting the exact payload shape, redaction policy, and both opt-out methods

Closes #362

Test Plan

• Added YAML roundtrip test for telemetryDisabled: true in repo_marker_repository_test.ts
• Added 4 unit tests for isTelemetryDisabledByConfig() covering: null marker, field absent, field false, field true
• All 1722 tests pass, deno check, deno lint, deno fmt clean

[github-actions]

Review Summary

This PR adds a telemetryDisabled configuration option to .swamp.yaml for persistent telemetry opt-out, along with documentation. The implementation is clean and follows project conventions.

No blocking issues found.

Analysis

Code Quality ✅

• TypeScript strict mode: No any types used
• Named exports used correctly (isTelemetryDisabledByConfig is properly exported)
• AGPLv3 license headers present in modified files
• Function has appropriate JSDoc with @internal tag for testing exports

Domain-Driven Design ✅

• RepoMarkerData is appropriately a data structure (Value Object pattern) - it represents configuration state without behavior
• The isTelemetryDisabledByConfig helper in mod.ts is a reasonable application service function that checks configuration
• No domain logic leakage - the check is at the infrastructure/CLI boundary

Test Coverage ✅

• 4 unit tests for isTelemetryDisabledByConfig() covering: null marker, field absent, field false, field true
• YAML roundtrip test for telemetryDisabled: true in repo_marker_repository_test.ts
• Tests follow the project convention of living next to source files

Security ✅

• No security concerns - this is a simple boolean flag for opting out of telemetry
• The check correctly uses strict equality (=== true) which handles edge cases properly

Documentation ✅

• README clearly documents the telemetry payload shape
• Both opt-out methods documented (per-invocation flag and persistent config)
• Redaction policy is clearly explained

Suggestions (Non-blocking)

1. Consider telemetry: false instead of telemetryDisabled: true - This is purely stylistic, but positive phrasing (telemetry: true/false) is often easier to reason about than double negatives. Not worth changing at this point.

2. Minor: Could add test for invalid values - The strict === true check handles this, but an explicit test showing that telemetryDisabled: "yes" or telemetryDisabled: 1 returns false could document the expected behavior. Low priority since the implementation is already correct.

LGTM! Well-structured feature with good test coverage and documentation.

[github-actions]

Code Review: feat: Add telemetryDisabled config to .swamp.yaml

Summary

This PR adds a telemetryDisabled configuration option to .swamp.yaml to allow users to persistently opt out of telemetry. The implementation is clean, well-tested, and follows the project's conventions.

---

✅ No Blocking Issues

The PR is ready to merge. All changes adhere to CLAUDE.md requirements and domain-driven design principles.

---

Code Quality Assessment

TypeScript Strict Mode Compliance: ✅

• No any types used
• All types are properly defined
• The telemetryDisabled?: boolean field correctly uses optional typing

Named Exports: ✅

• isTelemetryDisabledByConfig is a named export as required

License Headers: ✅

• All .ts files have the required AGPLv3 copyright header

Test Coverage: ✅

• 4 unit tests for isTelemetryDisabledByConfig() covering all edge cases (null marker, field absent, field false, field true)
• 1 YAML roundtrip test for persistence of telemetryDisabled: true
• Tests are properly placed next to source files (mod_test.ts, repo_marker_repository_test.ts)

Domain-Driven Design: ✅

• RepoMarkerData is correctly modeled as a simple data interface (persistence DTO) - appropriate for configuration data
• RepoMarkerRepository follows the repository pattern correctly, handling persistence for the swamp configuration
• isTelemetryDisabledByConfig() is a pure function with no side effects, correctly placed in the CLI layer where it's used

Security: ✅

• No security vulnerabilities introduced
• The feature properly allows users to opt out of telemetry, which is a privacy-positive change

Code Style: ✅

• Code is clean and follows existing patterns
• The @internal Exported for testing JSDoc annotation is consistent with the existing resolveModelsDir function
• The strict equality check === true is appropriate for handling potential non-boolean values from YAML parsing

---

Suggestions (Non-Blocking)

1. Documentation completeness: The README documentation is thorough and clearly explains the telemetry payload and opt-out methods. Consider mentioning that telemetryDisabled: true persists across all sessions while --no-telemetry is per-invocation only (though this may already be implied by "Permanently for a repository").

2. Test ordering: The new telemetry roundtrip test is placed between two createUpgradeMarker tests in repo_marker_repository_test.ts. This doesn't affect functionality but grouping related tests together (e.g., all roundtrip tests adjacent) could improve readability.

---

Verification

The PR description states all 1722 tests pass with clean deno check, deno lint, and deno fmt. The implementation is straightforward and low-risk.

LGTM! 👍