refactor: remove resourceId from ModelInput, use convention-based resource linking

[stack72]

• Remove resourceId field from ModelInput domain entity
• Adopt convention-based linking: resource ID always equals input ID
• Use existing inputIdToResourceId() helper consistently across all code paths
• Update AWS CloudControl delete operations to gracefully handle missing resources

Changes

Domain Model:

• Remove resourceId from ModelInputSchema, props, constructor, getter, setter, and serialization
• Delete setResourceId() method

Execution Paths:

• Remove resourceId updates in model_method_run.ts after method execution
• Remove resourceId updates in execution_service.ts during workflow execution
• Remove resourceId from method_execution_service.ts follow-up actions

Resource Resolution:

• Update model_resolver.ts to use inputIdToResourceId(input.id) for resource lookups
• Simplify resolveModel() to always derive resource ID from input ID

AWS CloudControl:

• Change delete behavior: instead of throwing when no resource exists, return "deleted" result
• Look up resource by derived ID and extract AWS identifier from attributes

Display Commands:

• Remove resourceId from model search and edit item mappings

Test plan

• All 1178 tests pass
• deno check - Type checking passes
• deno lint - No lint errors
• deno fmt - Properly formatted
• deno run compile - Binary compiles

🤖 Generated with Claude Code

[github-actions]

Review Summary

This PR implements a clean refactoring that removes the resourceId field from ModelInput in favor of a convention-based linking approach where resource ID always equals input ID. This is a well-executed simplification of the domain model.

No Blocking Issues Found

What Was Reviewed

Domain Model Changes

• ModelInput entity properly removes resourceId from schema, props, constructor, getter, setter, and serialization
• The inputIdToResourceId() helper function in model_resource.ts is used correctly throughout for the convention-based linking
• Design documentation updated to reflect the new convention

AWS CloudControl Model Changes

• executeDelete() now gracefully handles the case where no resource exists (returns success with deleteResource: true)
• Properly extracts AWS resource identifier from resource attributes
• Good error handling when unable to extract AWS resource identifier

Resolution Logic

• ModelResolver correctly updated to use inputIdToResourceId(input.id) for resource lookups
• Both buildModelData() and resolveModel() use the convention consistently

Test Coverage

• All three AWS model tests (EC2 Instance, Subnet, VPC) updated to reflect new behavior
• Tests properly verify the "delete method without resource returns deleted result" scenario
• ModelInput tests updated to remove resourceId-related assertions
• Good mock implementations for ResourceRepository in tests

Code Style

• Uses named exports (compliant with CLAUDE.md)
• No any types found in the changes
• TypeScript strict mode maintained

Suggestions (Non-Blocking)

1. Comment in ec2_instance_model_test.ts (line 19-26): The comment block at the top of the test file still shows resourceId in the example attributes. This is just a documentation comment and doesn't affect functionality, but could be cleaned up for consistency:

   /*
   Example instance attributes
   id: 9ad6033a-e77b-4e3b-8347-c5e10dad073b
   resourceId: 9ad6033a-e77b-4e3b-8347-c5e10dad073b  // <-- could remove this line
   ...
   */

2. The PR description mentions all 1178 tests pass, and the implementation is clean and consistent. The convention-based approach simplifies the domain model by eliminating redundant state tracking.

LGTM! 🎉