Conversation
Update design doc with include field in manifest, loader pre-check behaviour, and include file lifecycle through push/pull. Update extension model skill with helper scripts key rule and example showing include usage with a Deno.Command subprocess pattern. Update publishing reference with include file resolution in push steps. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
Documentation-only PR — verified all documented behavior against the actual codebase.
Blocking Issues
None.
Suggestions
-
Minor: Loader pre-check docs could mention all loader types —
design/extension.mdsays loaders check for "the expected named export (export const model,export const vault, etc.)" which is accurate but slightly vague. All five loaders (model, vault, driver, datastore, report) implement the same pre-check pattern. The current wording with "etc." is fine, but listing them explicitly could be more precise. Not blocking since the pattern is clear. -
Minor: Example
executesignature — In the helper scripts example inexamples.md, theexecutecallback uses(_args: unknown, context: { repoDir: string }). The_args: unknowntyping is consistent with Key Rule 7 ("No type annotations — avoid TypeScript types in execute parameters"), but it might be worth noting in a comment that the inlinecontexttype is just for illustration since real context comes from the runtime. Very minor — the example is clear as-is.
All documented behavior (include file resolution relative to modelsDir, safety analysis inclusion, quality check exclusion, archive placement under models/, loader pre-check regex) matches the implementation. Good docs update.
Summary
Documents the
includemanifest field and loader pre-check behaviour introduced in #849.Changes
design/extension.mdincludeto manifest Optional Fields section with descriptionmodels/, not bundled)swamp-extension-model/SKILL.mdincludefor files executed viaDeno.Commandsubprocess, links to examplesswamp-extension-model/references/examples.mdinclude, model that shells out to helper, helper script with native deps that isn't bundledswamp-extension-model/references/publishing.mdincludefilesincludefiles🤖 Generated with Claude Code