This repository was archived by the owner on Oct 9, 2020. It is now read-only.
chore(build): update build process#38
Merged
guybedford merged 1 commit intosystemjs:masterfrom May 29, 2016
Merged
Conversation
| "babel-preset-stage-3": "npm:babel-preset-stage-3@6.5.0", | ||
| "core-js": "npm:core-js@1.2.6", | ||
| "regenerator": "github:facebook/regenerator@0.8.42", | ||
| "regenerator": "github:facebook/regenerator@0.8.0", |
Member
There was a problem hiding this comment.
This might explain why regenerator@0.8.42 was not found!?
Member
|
I've actually just been working on some updates to this build, and it is worth noting that the build is created with the latest jspm beta. Once I've posted out this release today, that should work here as expected I think? |
douglasduteil
force-pushed
the
chore-build-update-build-process
branch
from
a6d5c40 to
956cd69
Compare
Contributor
Author
|
Yes ! Way better :) |
Contributor
Author
|
I rebased my PR. npm v regenerator@^0.8.42 version | tail -n 1 | awk '{print $2}' | tr -d "'" |
| @@ -87,7 +87,7 @@ exports.visitor = { | |||
| bodyBlockPath.node.body = innerBody; | |||
Member
There was a problem hiding this comment.
This file can be removed from the commit.
douglasduteil
force-pushed
the
chore-build-update-build-process
branch
2 times, most recently
from
7f048fc to
90721ad
Compare
Contributor
Author
|
🆙 I
|
Contributor
Author
|
I coded #41 on top of thie PR. |
| } | ||
|
|
||
| var outerFnExpr = getOuterFnExpr(path, state); | ||
| var outerFnExpr = getOuterFnExpr(path); |
Member
There was a problem hiding this comment.
All these , state argument are needed here actually.
Member
|
👍 |
douglasduteil
force-pushed
the
chore-build-update-build-process
branch
2 times, most recently
from
48b78f2 to
278f9de
Compare
douglasduteil
force-pushed
the
chore-build-update-build-process
branch
from
278f9de to
6198624
Compare
Contributor
Author
|
🆙 I didn't commit the generated files so you can do it at will ;) |
Member
|
Where would these workflows be without you @douglasduteil.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @guybedford
It way harder than expected to update babel (#34).
I tried to run your
build.shscript but it fails with :So given what you wrote I try to make a standalone build script with less environnement descendances. This PR is the state of this experiment.
However, I end up with a strange error from
babel-types@6.8.1:Do you have any idea where it comes from ?
Thanks
##
Full output: