This repository was archived by the owner on Oct 9, 2020. It is now read-only.
Fix root relative urls when there's no browserRootURL setting#138
Merged
guybedford merged 2 commits intosystemjs:masterfrom Feb 27, 2018
Merged
Fix root relative urls when there's no browserRootURL setting#138guybedford merged 2 commits intosystemjs:masterfrom
guybedford merged 2 commits intosystemjs:masterfrom
Conversation
This is the problem pointed out by @montoriusz in systemjs#135 (comment)
|
@papandreou I'm sorry, I can't test it in the original working environment. It would require rebuilding a dependency project and we stick to an older version for now. But I did review the change and it's ready to merge for me. The code looks a bit messy though. :-( |
Contributor
Author
|
Well, yeah, sorry about the mess. It would help to make a variant of the @guybedford, ping? |
Member
|
@papandreou sure, I've published a 0.1.37. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@montoriusz, could you test in your end that it fixes #135 (comment)?