Skip to content

Conversation

@t2d
Copy link
Contributor

@t2d t2d commented May 18, 2023

  • Install ansible-lint directly. Otherwise it didn't pickup the build dependencies.
  • Install role dependencies so we can lint their usage as well

Used in systemli/ansible-role-userli#47

@t2d t2d requested review from 0x46616c6b and xshadow as code owners May 18, 2023 23:14
@t2d t2d force-pushed the test_requirements branch from b16d5fb to 30791f7 Compare May 18, 2023 23:54
@0x46616c6b
Copy link
Member

I do not understand why we need the build dependencies for ansible-lint. Can you outline the reasons?

The other changes looks good to me.

@t2d
Copy link
Contributor Author

t2d commented May 19, 2023

I do not understand why we need the build dependencies for ansible-lint. Can you outline the reasons?

Sure, we need it to get rid of these warnings

With installed dependencies: https://github.com/systemli/ansible-role-userli/actions/runs/5019357705/jobs/8999749560#step:5:6

@t2d t2d merged commit 2b65885 into main May 20, 2023
@t2d t2d deleted the test_requirements branch May 20, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants