Skip to content

Fix usage of AliasRepository::findByUser method#1202

Merged
y3n4 merged 2 commits intomainfrom
fix-cross-domain-aliaslookup
Apr 22, 2026
Merged

Fix usage of AliasRepository::findByUser method#1202
y3n4 merged 2 commits intomainfrom
fix-cross-domain-aliaslookup

Conversation

@y3n4
Copy link
Copy Markdown
Contributor

@y3n4 y3n4 commented Mar 17, 2026 •
edited
Loading

  • ♻️ Split AliasRepository::findByUser into findByUser() (with domain filter) and findByUserAcrossDomains() (disables domain filter)
  • 🐛 Fix cross domain alias search in DeleteHandler and OpenPGPKeyController:
    • Allow to to manage OpenPGP keys for cross domain aliases
    • DeleteHandler::deleteUser($user) should delete aliases of $user from all domains

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 17, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@y3n4 y3n4 marked this pull request as ready for review March 18, 2026 12:23
t2d
t2d approved these changes Apr 18, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@t2d t2d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y3n4 y3n4 force-pushed the fix-cross-domain-aliaslookup branch from 9f6c281 to 6550271 Compare April 22, 2026 14:25
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 22, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@y3n4 y3n4 merged commit c1bce7a into main Apr 22, 2026
10 checks passed
@y3n4 y3n4 deleted the fix-cross-domain-aliaslookup branch April 22, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t2d t2d t2d approved these changes

@0x46616c6b 0x46616c6b Awaiting requested review from 0x46616c6b 0x46616c6b is a code owner

@doobry-systemli doobry-systemli Awaiting requested review from doobry-systemli doobry-systemli is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@y3n4 @t2d