✨ Introduce configurable Settings #887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x46616c6b
commented
Sep 17, 2025
| SENDER_ADDRESS="admin@example.org" | ||
| NOTIFICATION_ADDRESS="monitoring@example.org" | ||
| SEND_MAIL=1 | ||
| LOCALE="en" |
0x46616c6b
commented
Sep 17, 2025
| # For a generic SMTP server, use: "smtp://localhost:25" | ||
| # Delivery is disabled by default via "null://null" | ||
| MAILER_DSN="null://null" | ||
| MAILER_DELIVERY_ADDRESS="admin@example.org" |
0x46616c6b
commented
Sep 17, 2025
Comment on lines
-26
to
-39
| RETENTION_API_ENABLED=true | ||
| RETENTION_API_ACCESS_TOKEN="retention" | ||
| RETENTION_API_IP_ALLOWLIST="127.0.0.1, ::1" | ||
| KEYCLOAK_API_ENABLED=true | ||
| KEYCLOAK_API_ACCESS_TOKEN="keycloak" | ||
| KEYCLOAK_API_IP_ALLOWLIST="127.0.0.1, ::1" | ||
| POSTFIX_API_ENABLED=true | ||
| POSTFIX_API_ACCESS_TOKEN="postfix" | ||
| POSTFIX_API_IP_ALLOWLIST="127.0.0.1, ::1" | ||
| ROUNDCUBE_API_ENABLED=true | ||
| ROUNDCUBE_API_IP_ALLOWLIST="127.0.0.1, ::1" | ||
| DOVECOT_API_ENABLED=true | ||
| DOVECOT_API_ACCESS_TOKEN="dovecot" | ||
| DOVECOT_API_IP_ALLOWLIST="127.0.0.1, ::1" |
0x46616c6b
requested review from
doobry-systemli,
t2d and
y3n4
as code owners
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces a comprehensive settings management system that provides a configurable, database-backed solution for managing application settings. It includes YAML-based configuration definitions, a database entity for persistence, form-based UI for updates, and caching for performance optimization.
Key changes include:
- A new Settings entity and repository for database persistence
- Service layer with configuration and business logic for settings management
- Form integration with validation and type conversion
- Template updates for the settings UI with improved navigation and form display
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Entity/Setting.php | New database entity for storing settings with timestamps |
| src/Service/SettingsService.php | Core service handling settings CRUD operations with caching |
| src/Service/SettingsConfigService.php | Configuration service loading YAML-based settings definitions |
| src/Form/SettingsType.php | Dynamic form builder creating fields based on configuration |
| templates/Settings/show.html.twig | Updated settings template with form display and categorization |
| config/settings.yaml | YAML configuration defining available settings with validation rules |
| tests/ | Comprehensive test coverage for all new components |
| features/ | Split feature tests into separate files for better organization |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new, extensible system for managing application settings, including the configuration, persistence, form display, and update functionality. It adds a YAML-based settings definition, a database-backed entity for storing settings, and updates the controller logic and feature tests to support viewing and updating settings through the UI. The changes also refactor and split feature tests for API tokens and webhooks into dedicated files for better organization.