♻️ Use settings instead of environment variables #888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x46616c6b
requested review from
doobry-systemli,
t2d and
y3n4
as code owners
|
0x46616c6b
deleted the
Use-settings-instead-of-environment-variables
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors how application and project configuration values (such as name, URL, domain, and email addresses) are managed. Instead of relying on environment variables, these values are now accessed through a centralized
SettingsService. This change improves maintainability and flexibility, and affects message builders, command classes, service definitions, TOTP authentication, and translation files.Configuration management refactor:
APP_NAME,APP_URL,APP_DOMAIN,PROJECT_NAME,PROJECT_URL,PROJECT_LOGO_URL,SENDER_ADDRESS,NOTIFICATION_ADDRESS) from.envand.env.test