Complete an argument rename and silence byte-compiler #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes f3b11e1.
Calling it with two arguments, while still supported, is discouraged and the byte-compiler complains about it. If you plan to or end up releasing v2.0.N before v2.1, then you should probably adjust this.
Owner
|
Thank you for the fixes! I'll have a look at auto-compile; I would really like to make compilation errors and warnings harder to miss. |
Contributor
Author
|
You are welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please consider giving my
auto-compilepackage a try. It makes it much less likely that such mistakes go unnoticed.