update taproot-updates.md #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonilol
commented
May 10, 2022
antonilol
commented
May 10, 2022
antonilol
commented
May 10, 2022
antonilol
commented
May 10, 2022
antonilol
commented
May 10, 2022
antonilol
commented
May 10, 2022
taproot-updates.md
Outdated
| "tapleaf_2": " | ||
| # funds go to the remote node via a second-stage Claim-PTLC-success transaction by completing an adaptor sig, revealing the payment secret | ||
| # NB: we don't use musig2 here because it would force local and remote signatures to use the same sighash flags | ||
| <local_ptlcpubkey> OP_CHECKSIGVERIFY <remote_ptlcpubkey> OP_CHECKSIG |
Contributor
Author
There was a problem hiding this comment.
why are there two tapleaves when the only difference between the two is the order? one can be removed to save 32 vbytes
Contributor
Author
There was a problem hiding this comment.
this is only for readability, right?
- Save bytes in some scripts - Fix a script - Set sequence to 1 in second stage HTLC - Remove trailing whitespace
antonilol
force-pushed
the
taproot-updates
branch
from
84f6784 to
a45c7b6
Compare
antonilol
commented
May 10, 2022
Owner
|
Thanks for the feedback! I have one main comment though: I don't want the scripts here to be efficient, I want them to be as readable as possible. They can indeed be optimized (as you noticed), but this document should stay high-level(ish). Optimizing the scripts will be done with miniscript once we integrate Taproot in the bolts, that's where your proposal will make more sense. Can you please remove the script optimizations and keep the other changes? Thanks 🙏 |
Contributor
Author
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see the review comments at the specific lines