Skip to content

Fix: xYield withdraw from only callable by guardian#175

Merged
evchip merged 4 commits intocanaryfrom
fix/xyield-withdraw-from-only-callable-by-guardian
Sep 5, 2025
Merged

Fix: xYield withdraw from only callable by guardian#175
evchip merged 4 commits intocanaryfrom
fix/xyield-withdraw-from-only-callable-by-guardian

Conversation

@evchip
Copy link
Contributor

@evchip evchip commented Sep 4, 2025

Description

  • add onlyGuardian modifier to withdrawFrom

Motivation and Context

The remote withdrawal user has no share tokens on that chain, so we can only trust the guardian to withdraw the correct amount for the user.

How Has This Been Tested?

All existing tests passing.

Types of changes (remove all unchecked types)

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • If my change requires a change to the documentation, I have updated the documentation accordingly, and in either case, have checked this box to attest to my assessment of this requirement with regard to my change.
  • If my change requires additions or updates to any deployment scripts to ensure that the protocol is functional (Makefile, Dockerfile, Forge Script, etc.), I have made these changes, and in either case, have checked this box to attest to my assessment of this requirement with regard to my change.
  • If my change requires additional test coverage, I have created those tests accordingly, and in either case, have checked this box to attest to my assessment of this requirement with regard to my change.

from rebalance methods in order to emit event
Reason is the user has no share tokens on that chain, so we can only trust the guardian to withdraw
the correct amount for the user.
@evchip evchip requested a review from aharvet September 4, 2025 15:36
@evchip evchip self-assigned this Sep 4, 2025
Copy link
Contributor

@aharvet aharvet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@evchip evchip merged commit 372ef99 into canary Sep 5, 2025
4 checks passed
@evchip evchip deleted the fix/xyield-withdraw-from-only-callable-by-guardian branch September 5, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants