Revert v0.1.17 and release as v0.1.18#30
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughRemoves instanceId-based permission/session plumbing, deletes Slack message deduplication wiring, and updates permission tests. The package version changes from Remove instanceId and dedup plumbing
ChangesRemove instanceId and dedup plumbing
Sequence Diagram(s)Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Publish the v0.1.17 revert as 0.1.18 (npm version must increase monotonically; 0.1.16 is already taken). Code is identical to v0.1.16. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/index.ts`:
- Around line 176-183: Keep permission buttons tied to the specific Claude child
process that created them by adding a process-generation guard or clearing
pending permissions when that process exits. Update the permission flow in
onPermission and the forwarding logic around the sessionKey/Slack thread mapping
so stale buttons cannot be accepted by a replacement process. Use the existing
permissions.register and the child-process exit handling in src/index.ts to
ensure only the current process can receive forwarded clicks.
- Around line 382-391: The message routing in app.message is missing the
duplicate-suppression guard before dispatching to Claude, so Slack
retry/reconnect duplicates can be processed multiple times. Restore a small TTL
dedup check at the routing boundary in src/index.ts around the app.message
handler, using the existing message-dispatch flow and any related helper/state
used for at-least-once protection, while keeping the rest of the filter logic
unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 1e6c3870-9883-421c-8d07-b7f1ce061065
📒 Files selected for processing (8)
package.jsonsrc/claude.tssrc/dedup.test.tssrc/dedup.tssrc/index.tssrc/permission.test.tssrc/permission.tssrc/session.ts
💤 Files with no reviewable changes (3)
- src/dedup.ts
- src/claude.ts
- src/dedup.test.ts
|
Note CodeRabbit の指摘 2 件(権限ボタンの世代ガード欠如 / app.message の dedup 欠如)は、本 PR が v0.1.17 (#29) を意図的に revert していることに起因します。これらの堅牢化は v0.1.17 で追加されたものですが、v0.1.17 の変更に起因する不具合の調査のため、変更ごと取り消すのが本 PR の目的です。よって指摘はいずれも想定内であり、ここでは対応せず revert を維持します。 調査の結果 v0.1.17 の堅牢化を戻す場合は、別途 forward な PR で再導入します。 |
概要
最新版 v0.1.17 にバグがあるため、変更内容を打ち消して v0.1.18 として再リリースします。
877a43c(v0.1.17, #29 — Slack イベント重複排除 + 権限ボタン世代検証) を revert します。これらの変更そのものがバグ原因だったため取り消します。npm はバージョン単調増加が原則で 0.1.16 は使用済みのため、コードは v0.1.16 と同一のまま version のみ 0.1.18 に上げます。
内容
877a43cの revert コミット0.1.18v0.1.16タグと完全一致 (git diff v0.1.16は package.json の version 1 行のみ)src/dedup.ts,src/dedup.test.ts検証
pnpm typecheckパスpnpm test→ 99/99 パスリリース手順 (マージ後)
.github/workflows/release.ymlがv*.*.*タグ push で自動実行:@t2tx/iris@0.1.18が latest に)→ このマージ後に main で
v0.1.18タグを打って push する。備考
🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Refactor
Chores