fix: update governance scripts for recent root and API changes#487
Merged
fix: update governance scripts for recent root and API changes#487
Conversation
- Adds T81_CAPABILITIES_REPORT.md to the expected top-level list in scripts/governance/check_root_structure.py - Updates the SHA256 digest in docs/governance/PUBLIC_API_LOCK.json to match the current state of include/t81/**/*.hpp Co-authored-by: t81dev <207451414+t81dev@users.noreply.github.com>
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Replaced C++20 `= default` operator<=> with manual comparison operators in `T81String` to fix macOS Apple Clang (libc++) compilation errors. - Created a specialized `t81::v1::detail::int128_t` struct wrapper using MSVC intrinsics (`_umul128`, `_udiv128`) for Windows to prevent severe arithmetic bugs, buffer overruns, and `0xc0000409` aborts in T81BigInt. - Fixed hardcoded paths in `cli_contract_test.cpp` to correctly locate the build directory dynamically during Linux `cxx-std` testing. - Fixed `std::system` invocation in `cli_repro_hash_test.cpp` for Windows by quoting the full command for `cmd.exe` and safely stripping `\r`s. - Updated `PUBLIC_API_LOCK.json` to lock the new API changes. Co-authored-by: t81dev <207451414+t81dev@users.noreply.github.com>
- Fixed Windows Clang-cl `__divti3` linkage by allowing `_umul128` MSVC intrinsics. - Fixed MSVC compiler namespace resolution error for `detail::int128_t`. - Fixed macOS Apple Clang C++20 standard library template errors by implementing a manual `operator<=>` returning `std::strong_ordering` for `T81String`. - Fixed Linux test path matching failures in `cli_contract_test` by replacing hardcoded build directory assumptions with robust OS-level executable path discovery `discover_exe_path_internal()`. Co-authored-by: t81dev <207451414+t81dev@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
- Addressed MSVC `__divti3` missing runtime symbol by restricting intrinsic `int128_t` aliases within `t81::v1::detail` scope and removing the `!defined(__clang__)` Windows `clang-cl` condition constraint. - Fixed Apple Clang `isfinite` template parameter failure in `benchmark_runner.cpp` by explicitly casting `benchmark::Counter` to `double`. - Suppressed `CodeQL` `cpp/command-line-injection` false positive on the test binary path variable inside `cli_repro_hash_test.cpp`. - Adjusted test path validation logic in `cli_contract_test.cpp` to rely on the underlying OS API `discover_exe_path_internal()` to properly handle `build-cxxstd` non-standard CI build folders. Co-authored-by: t81dev <207451414+t81dev@users.noreply.github.com>
- Addressed `cpp/command-line-injection` alert raised by CodeQL in `cli_repro_hash_test.cpp` by replacing standard `std::system` invocation via string concatenation with explicit argument arrays passed to `execv` / `fork` on POSIX systems.
- Handled Windows invocation safety for `cli_repro_hash_test.cpp` by performing strict string validation (`filename().string().find("t81")`) prior to executing `std::system`.
- Promoted OS-level `<windows.h>` and `<unistd.h>` headers to the top of `tooling/cli/main.cpp` and introduced `#define NOMINMAX` and `#define WIN32_LEAN_AND_MEAN` flags to shield MSVC builds from namespace collisions while extracting dynamic executable paths.
- Cleaned up ephemeral workspace scripts and format modifications.
Co-authored-by: t81dev <207451414+t81dev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves failing GitHub Actions workflows (warn-strict, spec-and-docs) by updating governance verification scripts to allow recent repository changes.
PR created automatically by Jules for task 748535409174760989 started by @t81dev