Fix CMake build errors due to missing example sources#511
Conversation
The `examples/` directory was reorganized but `CMakeLists.txt` was not updated, causing CI build errors when trying to find source files like `examples/demo.cpp`. This commit updates all paths inside `CMakeLists.txt` and `tests/cpp/cli_contract_test.cpp` to correctly point to their respective subdirectories such as `ai-and-inference`, `compiler-and-ffi`, `storage-and-canonfs`, `core-language`, and `governance`. Co-authored-by: t81dev <207451414+t81dev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 15f1c611c0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,1180 @@ | |||
| ninja: Entering directory `build' | |||
There was a problem hiding this comment.
Drop transient CI logs from tracked sources
build.log/ctest.log are generated artifacts from a single local run, including environment-specific paths and stale test output, so checking them into the repo adds large non-source churn and makes future diffs/triage noisier without improving reproducibility. These files should be excluded from commits and kept as CI artifacts instead.
Useful? React with 👍 / 👎.
Greptile SummaryThis PR fixes CMake build errors caused by an However, the PR also commits two build artifacts that do not belong in source control:
Both files should be removed from this PR and added to Confidence Score: 4/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[examples/ directory reorganized] --> B{CMakeLists.txt updated}
A --> C{tests/cpp/cli_contract_test.cpp updated}
B --> B1[compiler-and-ffi/\ndemo.cpp\nir_roundtrip.cpp\ncomplex_demo.cpp]
B --> B2[ai-and-inference/\ntensor_ops.cpp\nmodel-load-canonfs/*.cpp\nai-integration/*.cpp]
B --> B3[governance/\naxion_demo.cpp\naxion_guard_trace.cpp\naxion_policy_*.cpp\ngovernance-demo/*.cpp]
B --> B4[storage-and-canonfs/\ncanonfs_trace_demo.cpp]
C --> C1[examples/core-language/\nhello_world.t81\n×2 references]
B1 & B2 & B3 & B4 --> OK[✅ Build succeeds]
C1 --> T[✅ t81_cli_contract_test_runner\nshould now pass]
style OK fill:#2d6a2d,color:#fff
style T fill:#2d6a2d,color:#fff
Reviews (1): Last reviewed commit: "Fix CMake build errors due to missing ex..." | Re-trigger Greptile |
| @@ -0,0 +1,1180 @@ | |||
| ninja: Entering directory `build' | |||
There was a problem hiding this comment.
Build artifacts committed to the repository
build.log and ctest.log are generated build artifacts and should not be committed to the repository. They are:
- environment-specific (contain absolute CI paths like
/app/...) - regenerated on every build, so they become stale instantly
- permanently embedded in git history, inflating repository size
These files should be added to .gitignore. Currently the .gitignore only covers pdf/*.log, leaving root-level logs unprotected. Both files should be removed from this PR and .gitignore should be updated:
# Build and CI artifacts
build.log
ctest.log
*.log
| 201/409 Test #204: t81_limb_bohemian_add_test ..................................... Passed 0.01 sec | ||
| Start 205: t81_limb_bohemian_mul_test | ||
| 202/409 Test #205: t81_limb_bohemian_mul_test ..................................... Passed 0.07 sec | ||
| Start 206: t81_limb_booth_mul_test |
There was a problem hiding this comment.
Committed test log represents an intermediate broken state
This ctest.log was captured after fixing CMakeLists.txt but before fixing tests/cpp/cli_contract_test.cpp. The log shows the failing test using the old path:
[cli] /app/build/t81 internal memory-stats /app/examples/hello_world.t81
test check failed: (memory_stats_result.exit_code == 0) at /app/tests/cpp/cli_contract_test.cpp:1694
The failure occurs because hello_world.t81 no longer exists at the root examples/ directory — it was moved to examples/core-language/. The cli_contract_test.cpp fix in this same PR updates that path, but the log was generated before that fix was applied.
This means the committed log documents a failure that the PR itself resolves, which is misleading. Reviewers cannot use this log as evidence that tests pass after the full set of changes in this PR is applied. The log should be removed from the PR entirely.
The previous commit introduced changes to path layouts. This commit fixes remaining CI failures: - Run `clang-format` on `tests/cpp/cli_contract_test.cpp` to resolve formatting check failure. - Fix broken links in `docs/status/AI_CLI_IMPLEMENTATION_MATRIX.md` and `docs/status/AI_CLI_MILESTONE_EVIDENCE.md` pointing to moved example shell scripts. - Add `Determinism Surface Registry` to determinism claims in `README.md` to satisfy the `check_determinism_claims.py` CI script. - Remove invalid link to `docs/glossary.md` in `README.md`. Co-authored-by: t81dev <207451414+t81dev@users.noreply.github.com>
Fix CMake build errors due to missing example sources
The
examples/directory was reorganized butCMakeLists.txtwas not updated, causing CI build errors when trying to find
source files like
examples/demo.cpp.This commit updates all paths inside
CMakeLists.txtandtests/cpp/cli_contract_test.cppto correctly point to theirrespective subdirectories such as
ai-and-inference,compiler-and-ffi,storage-and-canonfs,core-language,and
governance.PR created automatically by Jules for task 10346536587589323505 started by @t81dev