Fixed issue in tSQLt.Private_GetFullTypeName not handling fractional seconds precision on date and time types #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…seconds precision on date and time types
lizbaron
added a commit
that referenced
this pull request
Nov 24, 2020
…be it was updated by hand). Adding required tests (both for this PR and because some were missing): One is currently breaking on purpose. Please fix it. There is at least one more test required to ensure unique constraints.
mbt1
pushed a commit
that referenced
this pull request
Dec 1, 2020
added missing parameter to printout finished remaining tests for PR #16
Contributor
|
We implemented this manually because the merge did not work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A implementation to fix #15.
I have not been able to run the entire test suite, because I am not too sure how this should be done. I did however execute the Private_GetFullTypeNameTests test on sql2008R2 database with version 1.0.5873.27393.
Private_GetFullTypeNameTests.txt