chore(runner): Remove ENV_FILE#140
Merged
Merged
Conversation
Rename resolvePaths to resolveServiceDir and drop the .env.development loading
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #140 +/- ##
==========================================
- Coverage 89.45% 89.45% -0.01%
==========================================
Files 63 63
Lines 5900 5896 -4
==========================================
- Hits 5278 5274 -4
- Misses 488 489 +1
+ Partials 134 133 -1
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR updates the runner to stop injecting an ENV_FILE environment variable and removes per-service .env.development discovery, aligning service execution with a pure “inherit parent env” model.
Changes:
- Replaced
resolvePathswithresolveServiceDirand removed.env.developmentlookup +ENV_FILEinjection in the service start path. - Centralized the default service command as
config.DefaultServiceCommandand adjustedbuildCommand+ tests accordingly. - Updated
CLAUDE.mdto remove.env.developmentreferences and document the new environment behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/config/constants.go | Adds DefaultServiceCommand constant for the runner’s default start command. |
| internal/app/runner/service.go | Removes ENV_FILE injection / .env.development detection; renames path resolver; updates default command handling. |
| internal/app/runner/service_test.go | Updates buildCommand default expectations to match the new command construction. |
| CLAUDE.md | Removes outdated .env.development mentions and clarifies env inheritance behavior. |
Comments suppressed due to low confidence (1)
internal/app/runner/service.go:628
buildCommandnow always usessh -c(including the defaultmake runpath). This introduces an extra shell process compared to the previousexec.Command("make", "run")behavior, which changes the reported PID/Args and can affect process-tree/termination semantics (the tracked PID becomes the shell, not the direct command). If the goal is only to centralize the default command string, consider keeping the direct exec form for the default case and reservingsh -cfor explicitly custom commands (or represent the default as argv instead of a shell string).
// buildCommand creates an exec.Cmd from a command string, falling back to config.DefaultServiceCommand when empty
func buildCommand(command string) *exec.Cmd {
if command == "" {
command = config.DefaultServiceCommand
}
return exec.Command("sh", "-c", command)
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
resolvePathstoresolveServiceDirand drop the.env.developmentloading