Skip to content

chore(runner): Remove ENV_FILE#140

Merged
tab merged 1 commit into
masterfrom
chore/runner-envfile
Jun 2, 2026
Merged

chore(runner): Remove ENV_FILE#140
tab merged 1 commit into
masterfrom
chore/runner-envfile

Conversation

@tab

@tab tab commented Jun 2, 2026

Copy link
Copy Markdown
Owner

Rename resolvePaths to resolveServiceDir and drop the .env.development loading

Rename resolvePaths to resolveServiceDir and drop the .env.development loading
@tab tab requested a review from Copilot June 2, 2026 19:17
@tab tab self-assigned this Jun 2, 2026
@sentry

sentry Bot commented Jun 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.45%. Comparing base (8381c6b) to head (ca557db).

Files with missing lines Patch % Lines
internal/app/runner/service.go 85.71% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
- Coverage   89.45%   89.45%   -0.01%     
==========================================
  Files          63       63              
  Lines        5900     5896       -4     
==========================================
- Hits         5278     5274       -4     
- Misses        488      489       +1     
+ Partials      134      133       -1     
Files with missing lines Coverage Δ
internal/app/runner/service.go 82.47% <85.71%> (-0.20%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the runner to stop injecting an ENV_FILE environment variable and removes per-service .env.development discovery, aligning service execution with a pure “inherit parent env” model.

Changes:

  • Replaced resolvePaths with resolveServiceDir and removed .env.development lookup + ENV_FILE injection in the service start path.
  • Centralized the default service command as config.DefaultServiceCommand and adjusted buildCommand + tests accordingly.
  • Updated CLAUDE.md to remove .env.development references and document the new environment behavior.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
internal/config/constants.go Adds DefaultServiceCommand constant for the runner’s default start command.
internal/app/runner/service.go Removes ENV_FILE injection / .env.development detection; renames path resolver; updates default command handling.
internal/app/runner/service_test.go Updates buildCommand default expectations to match the new command construction.
CLAUDE.md Removes outdated .env.development mentions and clarifies env inheritance behavior.
Comments suppressed due to low confidence (1)

internal/app/runner/service.go:628

  • buildCommand now always uses sh -c (including the default make run path). This introduces an extra shell process compared to the previous exec.Command("make", "run") behavior, which changes the reported PID/Args and can affect process-tree/termination semantics (the tracked PID becomes the shell, not the direct command). If the goal is only to centralize the default command string, consider keeping the direct exec form for the default case and reserving sh -c for explicitly custom commands (or represent the default as argv instead of a shell string).
// buildCommand creates an exec.Cmd from a command string, falling back to config.DefaultServiceCommand when empty
func buildCommand(command string) *exec.Cmd {
	if command == "" {
		command = config.DefaultServiceCommand
	}

	return exec.Command("sh", "-c", command)
}

@tab tab merged commit 10dbb7f into master Jun 2, 2026
11 checks passed
@tab tab deleted the chore/runner-envfile branch June 2, 2026 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants