refactor(build): drop $_ prefix from helper variable names#20
Conversation
Rename $_moduleVersion → $moduleVersion and $_stagedOutput → $stagedOutput
in build.psake.ps1's properties block. Pure rename, no behavior change.
The $_ prefix was meant to signal "internal helper, not configuration"
but is easy to misread as the $_ automatic pipeline variable. The
shorter names are clearer in context (assignment targets in a
properties{} block, not script-block parameters).
Same rename applied across the user's downstream modules
(JsmOperations, PlexAutomationToolkit, ReScenePS) so the template and
all initialized modules stay in sync.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 29 minutes and 31 seconds.Comment |
There was a problem hiding this comment.
Pull request overview
This PR makes a small readability refactor in the build script by renaming two local helper variables in the properties {} block of build.psake.ps1. It fits into the build/test configuration added in PR #19 and keeps the staged-output coverage logic intact while removing names that can be visually confused with PowerShell’s $_ automatic variable.
Changes:
- Renames
$_moduleVersionto$moduleVersionin the coverage-path setup. - Renames
$_stagedOutputto$stagedOutputand updates the two coverage glob references. - Leaves the staged output/coverage behavior unchanged.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Summary
Rename
$_moduleVersion→$moduleVersionand$_stagedOutput→$stagedOutputinbuild.psake.ps1's properties block. Pure rename, no behavior change.Why
The
$_prefix was meant to signal "internal helper, not$PSBPreferenceconfiguration" — a convention I introduced in PR #19. Copilot flagged it on a downstream convergence PR as easy to misread as the$_automatic pipeline variable. Fair point: PowerShell parses$_<word>as a single identifier, so it's syntactically unambiguous, but the visual collision is real for anyone scanning the file.The shorter names are clearer in context (assignment targets in a
properties{}block, not script-block parameters where$_would actually mean something).Cross-repo sync
Same rename applied across the user's downstream PowerShell modules so the template and all initialized modules stay in sync:
tablackburn/JsmOperations— pushed tofeature/v0.1.0-mvptablackburn/PlexAutomationToolkit#47— pushed to fix branchtablackburn/ReScenePS#11— pushed to fix branchTest plan
🤖 Generated with Claude Code