ci(release): fail the PSGallery check on a query error instead of assuming not-published

[tablackburn]

Follow-up to the recovery-gap fix (#33). Now that Publish is gated only on the PSGallery check, that check's error handling matters: Find-Module -ErrorAction SilentlyContinue returns $null for both a genuine "not on gallery" and a transient query failure — so a network/PSGallery hiccup would be read as "not published" and trigger a blind publish attempt.

Fix: capture -ErrorVariable. A genuine not-found records no error (verified for an existing-module/new-version and a never-published module), so we publish only on a clean miss; a recorded error means the query itself failed → throw so the run is visibly retryable.

Surfaced by CodeRabbit + Copilot during the YouTubeMusicPS rollout review. Workflow YAML parses; no manifest change.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Chores
  • Enhanced error handling in the module publishing workflow. The version availability check now distinguishes between genuinely unavailable versions and transient query failures, ensuring accurate error detection. This prevents temporary network or service issues from being incorrectly interpreted as the module already being published.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d89beca5-f1c3-4c8b-a77f-a905436caa2b

📥 Commits

Reviewing files that changed from the base of the PR and between 090de78 and 282de8a.

📒 Files selected for processing (1)

• .github/workflows/PublishModuleToPowerShellGallery.yaml

---

📝 Walkthrough

Walkthrough

The publish workflow's PowerShell Gallery version check now distinguishes query failures from missing versions. The step captures Find-Module errors via -ErrorVariable and throws if an error occurs, instead of treating transient failures as legitimate absence. It only marks exists=false when the query succeeds with no results.

Changes

PSGallery Version Check Error Handling

Layer / File(s)	Summary
Find-Module error capture and failure behavior .github/workflows/PublishModuleToPowerShellGallery.yaml	The PSGallery existence check now uses -ErrorVariable to capture Find-Module query failures, throws with the captured error message if an error occurs, and only marks exists=false when the query succeeds without finding the module/version.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A query goes out to the gallery store,
Error handling now knows what's adore—
No silent failures, no false "not found,"
Transient mishaps are caught and unwound!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: improving error handling in the PSGallery version check by failing on query errors instead of assuming the module is not published.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ci/harden-psgallery-check

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR tightens the PowerShell Gallery “already published?” gate in the release workflow so that transient Find-Module query failures no longer get misinterpreted as “not published,” preventing accidental blind publish attempts when PSGallery/network hiccups occur.

Changes:

• Capture Find-Module failures via -ErrorVariable while still suppressing output with -ErrorAction SilentlyContinue.
• Fail the workflow explicitly (throw) when the PSGallery query errors, while continuing to treat a clean miss as “not published”.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[tablackburn]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.

[tablackburn]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.

[tablackburn]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.