TDVT 2.1.4 by lukewrites · Pull Request #430 · tableau/connector-plugin-sdk

lukewrites · 2020-01-02T22:53:44Z

Update smoke tests to count skipped & disabled tests as "pass". Also update the command line results from a TDVT run with more details. No longer count skipped/disabled tests as failures. #397
Refactor list command Fix unit test. #400 . list is used with suites and list-logical-configs is just for logical configs.
Fixes test rerun bug. Fix test rerun bug #378
Dev tdvt lriggs #405 Dev tdvt #407 Update tdvt_test.py #408

…to dev-tdvt-jainam

Lays the groundwork to count skipped & disabled tests. - Disabled tests still counted as failed.

* Add a really ugly type hint * Fix a type hint

- type hints

- type hints - add more detail to the cl test summary

Fix unit test.

power's going out; messy wip commit

This is shown if smoke tests all passed

Update constants and indent `failing_ds` block

Nicer formatting for test counts, test run time.

…to count-skipped-disabled-tests

- last step before merging.

No longer count skipped/disabled tests as failures.

…ake several seconds to run 0 tests.

- Removes unused line from `enqueue_failed_tests` that was causing errors.

Dev tdvt lriggs

Dev tdvt

Add unit tests for expected and unexpected error messages in the json

removing the print statement

update based on comments

Update tdvt_test.py

Fix test rerun bug

…te month

TFSID 1040094: Add in new tdvt test files to test snowflake datename does not truncate

Master into dev tdvt

File contents taken from github.com/github/gitignore.

pep8speaks · 2020-01-02T22:53:52Z

Thanks for updating the PR.

In the file tdvt/tdvt/tabquery.py:

Line 98:13: F405 'logging' may be undefined, or defined from star imports: .resources
Line 97:12: F405 'os' may be undefined, or defined from star imports: .resources
Line 93:1: E302 expected 2 blank lines, found 1

In the file tdvt/tdvt/tabquery_path.py:

Line 23:37: W292 no newline at end of file

In the file tdvt/tdvt/tdvt.py:

Line 533:121: E501 line too long (123 > 120 characters)
Line 444:121: E501 line too long (128 > 120 characters)
Line 443:121: E501 line too long (157 > 120 characters)
Line 440:121: E501 line too long (130 > 120 characters)
Line 246:9: F405 'logging' may be undefined, or defined from star imports: .tabquery
Line 229:5: E265 block comment should start with '# '
Line 21:1: E402 module level import not at top of file

In the file tdvt/tdvt/tdvt_core.py:

Line 671:33: F405 'TdvtInvocation' may be undefined, or defined from star imports: .resources, .test_results
Line 430:16: W503 line break before binary operator
Line 427:17: W503 line break before binary operator
Line 422:15: W503 line break before binary operator
Line 421:15: W503 line break before binary operator

In the file tdvt/test/tdvt_test.py:

Line 902:93: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 899:31: F405 'json' may be undefined, or defined from star imports: tdvt.tabquery, tdvt.test_results
Line 898:74: F405 'TestOutputJSONEncoder' may be undefined, or defined from star imports: tdvt.tabquery, tdvt.test_results
Line 898:28: F405 'json' may be undefined, or defined from star imports: tdvt.tabquery, tdvt.test_results
Line 894:121: E501 line too long (168 > 120 characters)
Line 891:121: E501 line too long (173 > 120 characters)
Line 889:27: F405 'TestErrorExpected' may be undefined, or defined from star imports: tdvt.tabquery, tdvt.test_results
Line 889:13: E117 over-indented
Line 886:89: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 883:27: F405 'json' may be undefined, or defined from star imports: tdvt.tabquery, tdvt.test_results
Line 882:70: F405 'TestOutputJSONEncoder' may be undefined, or defined from star imports: tdvt.tabquery, tdvt.test_results
Line 882:24: F405 'json' may be undefined, or defined from star imports: tdvt.tabquery, tdvt.test_results
Line 878:121: E501 line too long (164 > 120 characters)
Line 875:121: E501 line too long (169 > 120 characters)
Line 873:23: F405 'TestErrorExpected' may be undefined, or defined from star imports: tdvt.tabquery, tdvt.test_results
Line 872:5: E301 expected 1 blank line, found 0
Line 237:121: E501 line too long (122 > 120 characters)
Line 237:43: F405 'get_path' may be undefined, or defined from star imports: tdvt.tabquery, tdvt.test_results
Line 234:121: E501 line too long (140 > 120 characters)
Line 232:43: F405 'get_path' may be undefined, or defined from star imports: tdvt.tabquery, tdvt.test_results
Line 226:43: F405 'get_path' may be undefined, or defined from star imports: tdvt.tabquery, tdvt.test_results
Line 220:43: F405 'get_path' may be undefined, or defined from star imports: tdvt.tabquery, tdvt.test_results
Line 214:43: F405 'get_path' may be undefined, or defined from star imports: tdvt.tabquery, tdvt.test_results
Line 208:43: F405 'get_path' may be undefined, or defined from star imports: tdvt.tabquery, tdvt.test_results
Line 202:121: E501 line too long (158 > 120 characters)
Line 202:43: F405 'get_path' may be undefined, or defined from star imports: tdvt.tabquery, tdvt.test_results
Line 107:29: F405 'tabquerycli_exists' may be undefined, or defined from star imports: tdvt.tabquery, tdvt.test_results
Line 105:29: F405 'tabquerycli_exists' may be undefined, or defined from star imports: tdvt.tabquery, tdvt.test_results

Comment last updated at 2020-01-02 23:38:03 UTC

Create .gitignore file

jainam1995 and others added 30 commits November 18, 2019 22:58

Update tdvt.py

ca7a2db

add expected message from TestSet obj

a84b773

make sure default msg is '' and add type hints

166f53c

Merge branch 'dev-tdvt' of github.com:tableau/connector-plugin-sdk in…

6cfc40a

…to dev-tdvt-jainam

update CHANGELOG

b488179

pep8 nits

6eca625

Update helper functions to count skipped tests

ac7c8a2

Lays the groundwork to count skipped & disabled tests. - Disabled tests still counted as failed.

Refactor list/list-logical-configs.

5952762

Add & fix type hints

89f2cca

* Add a really ugly type hint * Fix a type hint

test counts working properly

2e93323

Fixed unit test to use Path.

7f7b866

Merge branch 'dev-tdvt' into dev-tdvt-lriggs

0cd3bdb

Update changelog.

631874f

Update tdvt_core.py

b54fa8f

- type hints

Update tdvt.py

16d97a5

- type hints - add more detail to the cl test summary

Merge pull request #400 from tableau/dev-tdvt-lriggs

c442b41

Fix unit test.

wip

11f8aa0

power's going out; messy wip commit

update type hint

2d695b9

remove enabled check so disabled tests are included & counted

c08bb7f

count all smoke tests, even disabled

5acca22

Bug fix - smoke test finished msg

cba7e1d

This is shown if smoke tests all passed

add to combined json

82ab60b

list comps to get passed/failed/disabled/skipped

9ccdfb0

remove unnecessary line

082983c

Update tdvt.py

569f3ec

Update constants and indent `failing_ds` block

Change test reporting

a0a6912

Nicer formatting for test counts, test run time.

Merge branch 'dev-tdvt' of github.com:tableau/connector-plugin-sdk in…

2793972

…to count-skipped-disabled-tests

add a line break

ec932f5

Update changelog

5af1fa1

- last step before merging.

Merge pull request #397 from tableau/count-skipped-disabled-tests

973de6c

No longer count skipped/disabled tests as failures.

Logan Riggs and others added 20 commits December 13, 2019 14:37

Cache list of tests for test_set. Fixed bug where run-pattern would t…

b63ab73

…ake several seconds to run 0 tests.

Style

21183f2

Remove buggy LOC

5eca1d0

- Removes unused line from `enqueue_failed_tests` that was causing errors.

Create failed_tests.json

fecb095

Update tdvt_test.py

0ad4c5f

Merge pull request #405 from tableau/dev-tdvt-lriggs

632ff3e

Dev tdvt lriggs

Merge pull request #407 from tableau/dev-tdvt

395692a

Dev tdvt

Update tdvt_test.py

2e98b9a

Add unit tests for expected and unexpected error messages in the json

Update tdvt_test.py

809c9be

removing the print statement

Update tdvt_test.py

aa5f101

update based on comments

Merge pull request #408 from tableau/dev-tdvt-jainam-unittest

ad22e84

Update tdvt_test.py

Merge pull request #378 from tableau/dev-tdvt-jainam

43989f1

Fix test rerun bug

add in new tdvt test files to test snowflake datename does not trunca…

85afd78

…te month

Merge pull request #418 from mirhyman/dev-tdvt

d611294

TFSID 1040094: Add in new tdvt test files to test snowflake datename does not truncate

Merge remote-tracking branch 'origin/master' into master-to-dev-tdvt

456508b

resolve merge conflict

57ed3b1

Merge pull request #427 from tableau/master-to-dev-tdvt

77edc10

Master into dev tdvt

Add .gitignore file

e3e3bd1

File contents taken from github.com/github/gitignore.

Add VS Code and PyCharm hidden dirs to gitignore

d26a562

Connector Packager and TDVT specific files

5de3afd

lukewrites added 2 commits January 2, 2020 14:54

update changelog for tdvt 2.1.4

8ac5c6d

update changelog for tdvt 2.1.4 (again)

783b58d

lukewrites requested review from jainam1995 and lriggs January 2, 2020 22:57

update project readme with TDVT 2.1.4

6489f13

lriggs approved these changes Jan 2, 2020

View reviewed changes

lukewrites added 2 commits January 2, 2020 15:35

Merge pull request #429 from tableau/add-gitignore

3e63543

Create .gitignore file

Merge branch 'master' into dev-tdvt

0a61d34

lukewrites merged commit 5e40743 into master Jan 3, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TDVT 2.1.4#430

TDVT 2.1.4#430
lukewrites merged 56 commits into
masterfrom
dev-tdvt

lukewrites commented Jan 2, 2020 •

edited

Loading

Uh oh!

pep8speaks commented Jan 2, 2020 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

lukewrites commented Jan 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pep8speaks commented Jan 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comment last updated at 2020-01-02 23:38:03 UTC

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lukewrites commented Jan 2, 2020 •

edited

Loading

pep8speaks commented Jan 2, 2020 •

edited

Loading