Update instructions for community page submission #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeshiaRose
approved these changes
May 14, 2020
Contributor
KeshiaRose
left a comment
KeshiaRose
left a comment
There was a problem hiding this comment.
Fixed old step number reference, looks good!
d45
approved these changes
May 14, 2020
| 5. First, host your extension on a web server (see below for suggestions). Second, create a manifest file (`.trex`) where the URL points to the hosted location of your extension. Finally, in your pull request, place the manifest file in the `community/CommunityManifests` folder. Also place the file name into your entry in community_extensions.json. Ensure the filename matches your manifest file and it is unique from others in the folder. | ||
|
|
||
| 6. Submit a pull request from the submissions branch of your fork to the submissions branch in the official repository. | ||
| 1. Submit a pull request from your fork to the master branch in the official repository. |
Contributor
There was a problem hiding this comment.
Do we still want them to open a PR to master?
Answer: Yes.
Contributor
Author
There was a problem hiding this comment.
Yes. it's simpler for them I believe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.