Skip to content

fix audit #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2021
Merged

fix audit #365

merged 1 commit into from
Feb 18, 2021

Conversation

@seanmakesgames
Copy link
Contributor

@seanmakesgames seanmakesgames commented Feb 17, 2021

No description provided.

shinchris
shinchris reviewed Feb 17, 2021
View reviewed changes
Copy link
Collaborator

@shinchris shinchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this generated by running npm update?
Also is the intention here to fix all of the dependabot alerts? It looks like there are a few left.

@seanmakesgames
Copy link
Contributor Author

seanmakesgames commented Feb 17, 2021 •
edited
Loading

Was this generated by running npm update?

This was done by doing npm audit fix.

Also is the intention here to fix all of the dependabot alerts? It looks like there are a few left.

Yes. Those alerts won't go away until this change is merged all the way to master. (this PR is off of dev)
After these changes, only two low sev issues remain (checked via npm audit), which is as intended.

@shinchris
Copy link
Collaborator

shinchris commented Feb 17, 2021

Ah okay, asking because ecstatic and eslint were two that I didn't see in the change, but are both set to moderate sev on github. Otherwise looks good!

@seanmakesgames
Copy link
Contributor Author

seanmakesgames commented Feb 17, 2021

Good catch -> those were probably sub-dependencies -- would be great if you checked out the branch and ran npm audit

shinchris
shinchris approved these changes Feb 17, 2021
View reviewed changes
Copy link
Collaborator

@shinchris shinchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, down to 2 low sev issues.

@seanmakesgames seanmakesgames merged commit 8a6eb4d into dev Feb 18, 2021
@seanmakesgames seanmakesgames deleted the smann/fix_audit branch February 18, 2021 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bcantoni bcantoni Awaiting requested review from bcantoni

@KeshiaRose KeshiaRose Awaiting requested review from KeshiaRose

1 more reviewer

@shinchris shinchris shinchris approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@seanmakesgames @shinchris