Fixed typo in datasources.html #414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file is called `datasources.js` and not `dataSources.js`, so the example was not working properly
johnDance
approved these changes
Sep 13, 2021
Contributor
Author
|
Hi @johnDance , thank you for merging my PR! I found that here https://tableau.github.io/extensions-api/docs/trex_getstarted.html is suggested to "Download the Tableau Extensions API SDK (.zip file) and extract the files to your computer." But the link is broken and I could not find any way to update that help section. |
Contributor
|
Thanks for pointing that out. We will get it fixed! @d45 - can you follow up on fixing the link? |
Contributor
|
Yes. Thanks for catching that. We changed the name of the branch, which changed the name of the zip file. I'll update that link and the link on the landing page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file is called
datasources.jsand notdataSources.js, so the example was not working properly