-
Notifications
You must be signed in to change notification settings - Fork 261
Fix / update links #468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix / update links #468
Conversation
Found and fixed a bunch of links after running a link checker on the whole site.
|
@d45 for your review please. For the fixed links I stuck with whatever style the file already had (full URL versus .md file), but we could update all of these to your style in a future PR if you want. The only non link changes are:
|
|
@bcantoni Thanks for running the link checker and making the fixes! The changes look good. |
|
@d45 good point - let me document here for my own recall as well:
The ignore for "googleapis" is because those were causing false alarms; the links work from a browser but not from the tool. The ignore for "localhost" is to avoid interpreting our "how to run locally" instructions as a real link. You could also run the linkchecker against the live docs on https://tableau.github.io/extensions-api/, but the tool runs so fast you can sometimes run into rate limits. Running against local has the benefit also of confirming as you fix things. I agree it would be great if a PR against the docs could generate both a hosted preview build and a link check against it. |
|
@bcantoni - awesome! I'm sure we could incorporate this check with our GitLab docs (Embedding API v3, Hyper API, etc.). |
seanmakesgames
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
|
@bcantoni Looks good. Got ahead and merge with |
Found and fixed a bunch of links after running a link checker on the whole site.