0.9.0 Release #79
Merged
0.9.0 Release #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdesmond46
previously approved these changes
Feb 12, 2018
Contributor
sdesmond46
left a comment
sdesmond46
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for adding all the comments to the sample
Samples/UINamespace/uiNamespace.html
Outdated
| <script src="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/js/bootstrap.min.js" ></script> | ||
|
|
||
| <!-- Extensions Library (this will be hosted on a CDN eventually) --> | ||
| <script src="../../lib/tableau-extensions-0.9.0.js"></script> |
Contributor
There was a problem hiding this comment.
Should we create some sort of tableau-extensions-0.latest.js version of the bootstrap so we don't always need to modify all of these?
Contributor
Author
There was a problem hiding this comment.
Yeah that's a good suggestion, I'll do that.
Samples/UINamespace/uiNamespace.js
Outdated
| }); | ||
|
|
||
| function configure() { | ||
| const popupUrl = 'http://localhost:8765/Samples/UINamespace/uiNamespaceDialog.html'; |
Contributor
There was a problem hiding this comment.
Should this use window.location to dynamically get this url?
Contributor
Author
There was a problem hiding this comment.
Good idea, will add.
Doc updates for 0.9.0 preview
Updated instructions for running extensions
Added UINamespace sample to the list
sdesmond46
previously approved these changes
Feb 14, 2018
sdesmond46
approved these changes
Feb 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains the necessary changes for the 0.9.0 release. This includes: