ci: fix v0.1.2 release — bump versions and add safety net#17
Merged
StefanSteiner merged 5 commits intoMay 18, 2026
Merged
Conversation
…lease release-please's simple strategy reads version.txt as its primary version source. Without it, the extra-files Generic updater for Cargo.toml was never invoked, leaving workspace version at 0.1.1 despite the v0.1.2 tag. Add version.txt (the simple strategy's expected file) and bump Cargo.toml workspace version to match the already-published v0.1.2 tag.
Verifies version.txt and Cargo.toml workspace version stay in sync. Runs on every PR including release-please PRs, catching the case where the simple strategy bumps version.txt but fails to update Cargo.toml (or vice versa) before merge.
release-please's linked-versions plugin failed to bump platform packages and hyperdb-api-node in the v0.1.2 release PR. The npm registry rejects re-publishing 0.1.1 since it already exists. Bump all package.json files and the manifest to 0.1.2 to match the tag.
Bump exact-version pins (=0.1.1 → =0.1.2) in hyperdb-api-core and hyperdb-api so cargo-deny resolves correctly. Add x-release-please-version annotations to both files and register them in extra-files so future releases bump these pins automatically.
The previous temp file naming scheme (PID + nanosecond timestamp) could collide on macOS where timer resolution is coarser than nanoseconds, causing parallel test runs to race on the same path. Switch to tempfile::NamedTempFile with into_temp_path() which uses OS-level atomic file creation and closes the handle before COPY (required on Windows where hyperd cannot read files held open by another process).
StefanSteiner
force-pushed
the
ssteiner/fix-release-v012
branch
from
bfc567e to
9ef21ad
Compare
This was referenced May 18, 2026
Closed
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v0.1.2 release-please PR (#15) didn't properly bump all versions:
Cargo.tomlworkspace version stayed at 0.1.1 (thesimplestrategy needsversion.txtto work)package.jsonfiles andhyperdb-api-node/package.jsonstayed at 0.1.1release.ymlto fail (tag/workspace mismatch) andnpm-build-publish.ymlto fail (E403 re-publishing 0.1.1)Fixes:
Cargo.tomlworkspace version to 0.1.2 and addversion.txt(the simple strategy's expected primary version file)package.jsonfiles and manifest to 0.1.2version-consistencyCI job that verifiesversion.txtmatchesCargo.tomlon every PR — catches this class of bug before mergeAfter merging:
Re-trigger the publish workflows against the v0.1.2 tag:
Test plan
release.ymlpasses the version check and publishes to crates.ionpm-build-publish.ymlpublishes 0.1.2 platform packages to npm