Skip to content

ci: force generic updater for Cargo.toml extra-files#19

Merged
StefanSteiner merged 1 commit into
tableau:mainfrom
StefanSteiner:ssteiner/fix-release-please-toml
May 18, 2026
Merged

ci: force generic updater for Cargo.toml extra-files#19
StefanSteiner merged 1 commit into
tableau:mainfrom
StefanSteiner:ssteiner/fix-release-please-toml

Conversation

@StefanSteiner
Copy link
Copy Markdown
Contributor

Summary

  • Bare string entries (e.g. "Cargo.toml") in release-please's extra-files trigger the GenericToml updater (JSONPath-based), which ignores x-release-please-version annotation comments entirely.
  • This caused PR chore: release main #18 to bump version.txt to 0.1.3 without touching the Cargo.toml files, failing the version-consistency CI check.
  • Fix: explicitly set "type": "generic" on all three Cargo.toml extra-file entries so the annotation-based updater processes them.

Test plan

  • Merge this PR (use ci: prefix so no version bump)
  • Close and reopen PR chore: release main #18 (or wait for release-please to regenerate it)
  • Verify PR chore: release main #18's diff now includes Cargo.toml version bumps to 0.1.3
  • Verify version-consistency CI check passes

Bare string entries in extra-files trigger GenericToml (JSONPath-based)
which ignores x-release-please-version annotation comments. Explicitly
set type: "generic" so the annotation-based updater processes these.
@StefanSteiner StefanSteiner merged commit b262e9c into tableau:main May 18, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant