ci: fix release-please extra-files updater for Cargo.toml#22
Merged
StefanSteiner merged 3 commits intoMay 18, 2026
Merged
Conversation
- Root Cargo.toml: use type "toml" with jsonpath ($.workspace.package.version) — the GenericToml updater parses TOML structurally rather than looking for annotation comments. - Inter-crate pins: use type "generic" with block markers (x-release-please-start-version / x-release-please-end) since the Generic updater needs the annotation on/around the version line. - Remove stale preceding-line annotations that the Generic updater doesn't support. - Update version-consistency CI check to not depend on the removed annotation comment.
GITHUB_TOKEN suppresses workflow triggers on events it creates. Switch to a fine-grained PAT (RELEASE_PLEASE_TOKEN) so release-please PRs trigger CI and its tags trigger release/npm-publish workflows. Also documents both the PAT approach (current) and the GitHub App token alternative in GITHUB_OPERATIONS.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cargo.toml: switch totype: "toml"withjsonpath: "$.workspace.package.version"— the previous bare-string andtype: "generic"approaches both silently failed because release-please auto-selects GenericToml for.tomlfiles (which uses JSONPath, not annotations).hyperdb-api-core/Cargo.toml,hyperdb-api/Cargo.toml): switch to block markers (x-release-please-start-version/x-release-please-end) which the Generic updater actually supports (preceding-line annotations don't work).This is the third attempt at getting release-please to update Cargo.toml files. The previous two approaches failed because:
"Cargo.toml"→ triggers GenericToml (ignores annotations)type: "generic"with preceding-line annotation → Generic updater only matches annotations on the same line or via block markersTest plan
release-please--branches--mainbranch if it existsgh workflow run release-please.yml