Skip to content

Conversation

@djfrancesco
Copy link
Contributor

No description provided.

@vogelsgesang
Copy link
Contributor

Thanks for your contribution! :)

The code itself looks good. However, it does not fit to the corresponding README of that folder...
The README states that the samples in that folder would be from a hands-on training, but your code is not.

Can you please adjust the README accordingly?

@djfrancesco
Copy link
Contributor Author

Hi @vogelsgesang, I tried to update the local README file, tell me if it's OK or if you want me to add more things.
François

@jonas-eckhardt
Copy link
Contributor

Thanks for the contribution. I think we should separate this example from the native-s3 one as this one is from the Hands on training at TC22. Can you potentially just create a new folder under "Community Supported" with its own readme?

@djfrancesco
Copy link
Contributor Author

Jonas, I created a new folder named s3-compatible-services, is the name OK?
I also added a specific README file.

@jonas-eckhardt
Copy link
Contributor

Ship it 🚢

@vogelsgesang vogelsgesang merged commit a0935cb into tableau:main Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants