Test Coverage for unit tests

[graysonarts]

Not too bad all things considered, but there are some notable holes we should probably add extra coverage to.

Name                                                          Stmts   Miss  Cover
---------------------------------------------------------------------------------
tableauserverclient/__init__.py                                   5      0   100%
tableauserverclient/models/__init__.py                           15      0   100%
tableauserverclient/models/connection_credentials.py             11      5    55%
tableauserverclient/models/connection_item.py                    38      0   100%
tableauserverclient/models/datasource_item.py                   104      5    95%
tableauserverclient/models/exceptions.py                          2      0   100%
tableauserverclient/models/fileupload_item.py                    17     10    41%
tableauserverclient/models/group_item.py                         39      0   100%
tableauserverclient/models/interval_item.py                     112      9    92%
tableauserverclient/models/pagination_item.py                    22      0   100%
tableauserverclient/models/project_item.py                       59      1    98%
tableauserverclient/models/property_decorators.py                63      6    90%
tableauserverclient/models/schedule_item.py                     145      5    97%
tableauserverclient/models/server_info_item.py                   21      0   100%
tableauserverclient/models/site_item.py                         147     14    90%
tableauserverclient/models/tableau_auth.py                       14      6    57%
tableauserverclient/models/tag_item.py                           13      0   100%
tableauserverclient/models/user_item.py                         111      4    96%
tableauserverclient/models/view_item.py                          56      6    89%
tableauserverclient/models/workbook_item.py                     146      8    95%
tableauserverclient/namespace.py                                  1      0   100%
tableauserverclient/server/__init__.py                            9      0   100%
tableauserverclient/server/endpoint/__init__.py                  12      0   100%
tableauserverclient/server/endpoint/auth_endpoint.py             34      3    91%
tableauserverclient/server/endpoint/datasources_endpoint.py     100     21    79%
tableauserverclient/server/endpoint/endpoint.py                  40      0   100%
tableauserverclient/server/endpoint/exceptions.py                16      0   100%
tableauserverclient/server/endpoint/fileuploads_endpoint.py      46     31    33%
tableauserverclient/server/endpoint/groups_endpoint.py           78      4    95%
tableauserverclient/server/endpoint/projects_endpoint.py         40      0   100%
tableauserverclient/server/endpoint/schedules_endpoint.py        46      8    83%
tableauserverclient/server/endpoint/server_info_endpoint.py      11      0   100%
tableauserverclient/server/endpoint/sites_endpoint.py            59      4    93%
tableauserverclient/server/endpoint/users_endpoint.py            60      1    98%
tableauserverclient/server/endpoint/views_endpoint.py            23      0   100%
tableauserverclient/server/endpoint/workbooks_endpoint.py       137     12    91%
tableauserverclient/server/exceptions.py                          2      0   100%
tableauserverclient/server/filter.py                             19      3    84%
tableauserverclient/server/pager.py                              25      2    92%
tableauserverclient/server/request_factory.py                   273     42    85%
tableauserverclient/server/request_options.py                    41      1    98%
tableauserverclient/server/server.py                             64      6    91%
tableauserverclient/server/sort.py                                6      3    50%
---------------------------------------------------------------------------------
TOTAL                                                          2282    220    90%

[t8y8]

Visualizations woo!

The biggest misses all seem to be 'serializer' like tests, which wouldn't hurt to add.

sort.py and fileupload_item.py are low too -- sort can be tested via the requests tests I added (query strings and such) and fileupload may be a bit tricky, but should be doable

[talvalin]

As suggested above, I started with sort.py tests and created a couple of tests for the equals filter and sort asc. However, despite chatting with @t8y8, I still have no idea how to use coverage.py to verify that I'm improving the situation.

For example, if I run coverage run sort.py directly, then I get the exact same result as above. However, how is that factoring in my newly written test file? I strongly suspect I'm missing something here but I can't get my head around it.

[talvalin]

When combining filters the ordering of the filters in the client request is not consistent between test runs, so my assertEqual for multiple filter conditions intermittently fails. Is this something that needs to be addressed?

[t8y8]

It's possible that the attributes pass through a dictionary at some point, or a set, which don't guarantee order. Can you post a PR and I can take a look @ the code

[talvalin]

Already done! :) Try the commented out test a few times and it should repro soon enough.

…

On 16 Jan 2017 8:36 p.m., "Tyler Doyle" ***@***.***> wrote: It's possible that the attributes pass through a dictionary at some point, or a set, which don't guarantee order. Can you post a PR and I can take a look @ the code — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#101 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABfQU-tAdLEiu-bA1_p3vQlToEnfAQnbks5rS1YrgaJpZM4KtAjq> .

[talvalin]

The code for request_options.py indicates that both the sort and filter attributes are sets, which would explain that.

[graysonarts]

Oh good catch. I'll get a fix for that so we are deterministic out for PR today.

[graysonarts]

I think we are good here.