Fix large downloads (#105) #111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've got a working solution for #105
Requests provides a way to just get the response headers back and then iterating over the content in chunks. This lets us stream to disk instead of trying to hold large workbooks in memory.
(See http://docs.python-requests.org/en/master/api/#requests.Response.iter_content and http://docs.python-requests.org/en/master/user/advanced/#body-content-workflow)
As a proof of concept I extended our wrapper methods to allow per-call http options (because we don't need to stream every request) and then tested it on workbook download with the script below.
If this approach works, I can clean it up and add it to data source download as well.
But a few questions:
get_download_requestinsteadstream=TrueI think I'm right but may want to just wrap it all in a context manager or try/except