push code for 0.24 #1168
Merged
push code for 0.24 #1168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jacalata
commented
Jan 6, 2023
jacalata
commented
- session injection
- show detailed errors when unable to connect to server
- excel request options and docs
- when deleting extract from workbook, choose between 'all' and specific datasources
- when no protocol is given, assume http
- handle redirect on login for e.g http://online.tableau.com work to redirect to http://east.online.tableau.com
- add default permissions for data roles and metrics
- allow calling code to set the user agent
* ssl-verify is an option, not a header
* Allow injection of session_factory to allow use of a custom session
Pylint with "errors only" isn't 100% accurate, but it found a few problems that should be fixed.
* fix behavior when url has no protocol
* smoke test for pypi
bring over fix from test repo
* add option to pass specific datasources * mypy no-implicit-optional
Allow publishing using connection credentials on ConnectionItem class without ConnectionCredentials instance, as documented Accept empty string for username or password in connection credentials Avoid Tableau Server internal server error when publishing with empty connection list by setting connections to None
* fix revision references where xml returned does not match docs
This should fix (1) from #1139 (comment), by preventing us from sending an empty connections element if the list of connections is empty.
anyoung-tableau
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.