Reword no_extract and update signature of added_in #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGraber
reviewed
Feb 18, 2017
Contributor
LGraber
left a comment
LGraber
left a comment
There was a problem hiding this comment.
We have a bit of a problem since this is all being merged in development but it has not released yet. It seems we need some type of vnext and vnextnext so that we can deal with multiple delayed versions. This does not seem like it should have been in development (the no_extract feature) yes.
Collaborator
Author
|
It makes use of (and added to) the new 'annotation' functionality, so this will just throw when called against a Server that doesn't support it with a nice clear error, and it unblocked testing against the 10.2 beta. I discussed w/ @RussTheAerialist and we agreed that larger changes should go into vnext, but this was pretty minor and is protected against being used against a current version (see |
graysonarts
pushed a commit
that referenced
this pull request
Mar 23, 2017
`parameter_added_in` got a facelift and now takes keyword arguments, where the value represents the version for that keyword. It looks a little cleaner and makes the checking code much simpler. Also renamed the `extract_only` to be `no_extract` because it means the opposite of `extract_only`, oops.
graysonarts
pushed a commit
that referenced
this pull request
Apr 14, 2017
`parameter_added_in` got a facelift and now takes keyword arguments, where the value represents the version for that keyword. It looks a little cleaner and makes the checking code much simpler. Also renamed the `extract_only` to be `no_extract` because it means the opposite of `extract_only`, oops.
t8y8
pushed a commit
to t8y8/server-client-python
that referenced
this pull request
Jun 28, 2017
…leau#175) `parameter_added_in` got a facelift and now takes keyword arguments, where the value represents the version for that keyword. It looks a little cleaner and makes the checking code much simpler. Also renamed the `extract_only` to be `no_extract` because it means the opposite of `extract_only`, oops.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that the feature is to not download the extract, not to only download the extract.
Oops.
I also changed the way the
parameter_added_indecorator works after @RussTheAerialist recommended a little cleaner api.Again manually tested that it works like it should, plus it gets exercised by unittests already in place.