This repository was archived by the owner on Jan 28, 2026. It is now read-only.
feat: add --format flag to deals for table or json#19
Merged
dtbuchholz merged 2 commits intomainfrom Nov 14, 2023
Merged
Conversation
d0b3595 to
67636ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds a small feature to format the output of
dealsas either a table (default) or json. It also makes small changes to the README for a SUPERUSER publication creation requirement and a simple example of how to use Basin with Supabase.Details
Here's an example of how it works:
Note: it appears the current output doesn't map things properly. I didn't want to touch this since I'm assuming the mis-mapping is due to future changes we're making, but for example, you can see the CID is in the wrong column:
Added JSON type annotations to the
DealInfostruct underinternal/app/basin_provider.go:In
cmd/basin/publication.go, added aformatoption:This will let a
--formatflag be passed with eithertableorjson, and it errors if an invalid string is passed:Tested by manually building since it doesn't seem like there's an existing test for this and I didn't want to mess with anything.