Conversation
avichalp
force-pushed
the
avichalp/type-remapping
branch
from
643282c to
8307bf2
Compare
Signed-off-by: avichalp <hi@avichalp.me>
Signed-off-by: avichalp <hi@avichalp.me>
Signed-off-by: avichalp <hi@avichalp.me>
Signed-off-by: avichalp <hi@avichalp.me>
Signed-off-by: avichalp <hi@avichalp.me>
avichalp
force-pushed
the
avichalp/type-remapping
branch
from
8307bf2 to
d1018fd
Compare
| c.column_name, | ||
| pg_catalog.format_type(t.oid, NULL) AS full_data_type | ||
| FROM information_schema.columns AS c | ||
| JOIN pg_catalog.pg_type AS t ON c.udt_name = t.typname |
There was a problem hiding this comment.
Enhances the inspect query to get metadata for columns of type ARRAY.
| // pgToDDBType maps a PG type to a duckdb type. | ||
| func (dbm *DBManager) pgToDDBType(typ string) (duckdbType, error) { | ||
| // handle character(N), character varying(N), numeric(N, M) | ||
| if strings.HasSuffix(typ, ")") { |
There was a problem hiding this comment.
Handle edge cases and finds appropriate type from typeConversionMap
There was a problem hiding this comment.
suggestion: use strings.Cut, instead of strings.Split. example: https://go.dev/play/p/J4OwaJGJqyB
| // typeConversionMap maps PG types to duckdb types. | ||
| // currently, only a subset of PG types are supported. | ||
| // Custom enum types, sturcts, multi-dimensional arrays are not supported. | ||
| var typeConversionMap = map[string]duckdbType{ |
There was a problem hiding this comment.
PG type is mapped to a DuckDB type and a transform function that will transform the column value from the WAL JSON into value that can be used in the Duck DB query.
brunocalza
left a comment
brunocalza
left a comment
There was a problem hiding this comment.
Nice work! Looks like you exhaustively tested all types, really nice. Looks good to me! Could not find any problem, lmk if you need help with manual tests
2 participants
This pull request introduces type conversion between Postgres and DuckDB. Most of the Postgres data types are mapped to equivalent DuckDB but there are three exceptions. The following types are not supported in this PR but can be added later.