This repository was archived by the owner on Jan 28, 2026. It is now read-only.
renaming commands to vaults terminology#29
Merged
brunocalza merged 17 commits intomainfrom Dec 19, 2023
Merged
Conversation
brunocalza
changed the title
brunocalza
changed the title
Signed-off-by: Bruno Calza <brunoangelicalza@gmail.com>
brunocalza
force-pushed
the
bcalza/rename
branch
from
0c541e0 to
f0e1bee
Compare
Signed-off-by: Bruno Calza <brunoangelicalza@gmail.com>
brunocalza
requested review from
avichalp,
dtbuchholz and
sanderpick
and removed request for
dtbuchholz and
sanderpick
dtbuchholz
approved these changes
Dec 15, 2023
Contributor
dtbuchholz
left a comment
dtbuchholz
left a comment
There was a problem hiding this comment.
looks good from my perspective!
avichalp
reviewed
Dec 18, 2023
cmd/vaults/commands.go
Outdated
| "gopkg.in/yaml.v3" | ||
| ) | ||
|
|
||
| var pubNameRx = regexp.MustCompile(`^([a-zA-Z_][a-zA-Z0-9_]*)[.]([a-zA-Z_][a-zA-Z0-9_]*$)`) |
Contributor
There was a problem hiding this comment.
pubNameRx got left behind
Improve CLI help, add versioning, & `list`/`retrieve` enhancements
brunocalza
force-pushed
the
bcalza/rename
branch
2 times, most recently
from
5d9050c to
380a582
Compare
Signed-off-by: Bruno Calza <brunoangelicalza@gmail.com>
brunocalza
force-pushed
the
bcalza/rename
branch
from
380a582 to
67ece26
Compare
Signed-off-by: Bruno Calza <brunoangelicalza@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the commands to Textile Vaults terminology (and also the code names)
This is kind of hard to review, so take a look at the new README.md and see if the new names make sense. Also, check out the config migration (and if possible, help to test it). It should copy the file
.basin/config.yamlto.vaults/config.yaml.obs: the
writecommand descriptions still is "write a Parquet file" because the backend still assumes a Parquet file, although I know we're planning to accept any kind of data