Skip to content
This repository was archived by the owner on Jan 28, 2026. It is now read-only.

Cache and cold storage retrieve the same content#37

Merged
brunocalza merged 1 commit intomainfrom
bcalza/retrieveimprov
Feb 28, 2024
Merged

Cache and cold storage retrieve the same content#37
brunocalza merged 1 commit intomainfrom
bcalza/retrieveimprov

Conversation

@brunocalza
Copy link
Contributor

This PR introduces the following changes:

  • The retrieve command behavior is modified so that the --output flag is expected to be a filename
  • When the CAR file is retrieved from cold storage, it is unpacked. That means both cache and cold storage should retrieve the same content

Signed-off-by: Bruno Calza <brunoangelicalza@gmail.com>
@brunocalza brunocalza changed the title make the cache and cold storage return the same content Cache and cold storage retrieve the same content Feb 28, 2024
@brunocalza brunocalza marked this pull request as ready for review February 28, 2024 19:17
@brunocalza brunocalza self-assigned this Feb 28, 2024
Copy link
Contributor

@dtbuchholz dtbuchholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 (and i can rebase my PR once we merge this to main)

@brunocalza brunocalza merged commit 6044303 into main Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants