Skip to content

ADMINPORT-39 Add service to update the payment profile for a user subscription#24

Merged
krmannix merged 3 commits intomasterfrom
feature/ADMINPORT-39
May 16, 2016
Merged

ADMINPORT-39 Add service to update the payment profile for a user subscription#24
krmannix merged 3 commits intomasterfrom
feature/ADMINPORT-39

Conversation

@krmannix
Copy link
Copy Markdown
Contributor

Goals

Add a route to update a subscription's payment method.

Results

Check all that apply to this pull request

  • New Feature

Checklist

Check off all items in this list before asking for a code review:

  • I added unit tests for the new feature or bug fix
  • I added code documentation to any new services or methods

Comment thread src/user/resource.js
},
subscriptionAction: {
method: "POST",
url: endpoint + '/subscription/:subscriptionId/action',
Copy link
Copy Markdown
Member

@officert officert May 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add

params : {
    subscriptionId : '@subscriptionId'
}

this tells Angular that the subscriptionId param should be used in the URL and not passed as a query string.

@officert
Copy link
Copy Markdown
Member

1 minor comment, otherwise looks good 👍 let me know if you want to go through how to release these changes to Bower.

@krmannix
Copy link
Copy Markdown
Contributor Author

@officert cool, just updated. And yeah, it'd be good to run through that quick just to see how it's done

@krmannix krmannix merged commit 228b1d6 into master May 16, 2016
@krmannix krmannix deleted the feature/ADMINPORT-39 branch May 16, 2016 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants