ADMINPORT-39 Add service to update the payment profile for a user subscription#24
Merged
ADMINPORT-39 Add service to update the payment profile for a user subscription#24
Conversation
| }, | ||
| subscriptionAction: { | ||
| method: "POST", | ||
| url: endpoint + '/subscription/:subscriptionId/action', |
Member
There was a problem hiding this comment.
You need to add
params : {
subscriptionId : '@subscriptionId'
}
this tells Angular that the subscriptionId param should be used in the URL and not passed as a query string.
Member
|
1 minor comment, otherwise looks good 👍 let me know if you want to go through how to release these changes to Bower. |
Contributor
Author
|
@officert cool, just updated. And yeah, it'd be good to run through that quick just to see how it's done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals
Add a route to update a subscription's payment method.
Results
Check all that apply to this pull request
Checklist
Check off all items in this list before asking for a code review: