Support blacklisted_names in //aws/vpc/subnets #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, we’ve skipped a subnet for historical reasons, and we have subnets like
us-east-1a,us-east-1c,us-east-1d, and so on.This PR allows migrating these historical use cases to the //aws/vpc/subnets module without having to rebuild the subnets, through the support of
blacklisted_namesas a variable. By specifying it, one can skip over an availability zone. In addition to this, removing the manual, hard-coded mapping of letters to numbers, and replacing it with a count-based index only, allows us to maintain the existing AZ-to-subnet-CIDR-block mapping, enabling us to use the module without rebuilding everything in the VPC.