New CTA type. End/start date changed to string in campaign#71
Merged
vladimanaev merged 6 commits intotaboola:masterfrom Apr 27, 2023
Merged
New CTA type. End/start date changed to string in campaign#71vladimanaev merged 6 commits intotaboola:masterfrom
vladimanaev merged 6 commits intotaboola:masterfrom
Conversation
vladimanaev
reviewed
Apr 24, 2023
vladimanaev
reviewed
Apr 24, 2023
vladimanaev
reviewed
Apr 24, 2023
Author
Comments are resolved |
vladimanaev
requested changes
Apr 27, 2023
| public class Campaign { | ||
|
|
||
| private final String EXTENDED_DATE_TIME_FORMAT = "yyyy-MM-dd HH:mm:ss"; | ||
| protected final String DATE_TIME_FORMAT = "yyyy-MM-dd"; |
Collaborator
There was a problem hiding this comment.
Make the pattern fields 'private static final'
Author
There was a problem hiding this comment.
Because DATE_TIME_FORMAT was used in the CampaignOperation added one more SimpleDateFormat
| */ | ||
| public class Campaign { | ||
|
|
||
| private final String EXTENDED_DATE_TIME_FORMAT = "yyyy-MM-dd HH:mm:ss"; |
Collaborator
There was a problem hiding this comment.
Make the pattern fields 'private static final'
| @@ -21,6 +23,9 @@ | |||
| */ | |||
| public class Campaign { | |||
Collaborator
There was a problem hiding this comment.
Please create unit test that test the date functionality
vladimanaev
previously approved these changes
Apr 27, 2023
vladimanaev
approved these changes
Apr 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.