-
Notifications
You must be signed in to change notification settings - Fork 213
feat(stdlib): optimize sha256() and add keccak256()
#2775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
anton-trunov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's not change the FunC benchmarks in this PR
The FunC benchmarks do not use the If I revert the changes to benchmarked JSONs then CI won't pass :) UPD: Looking for the source of trouble. As @anton-trunov pointed out, the reason might be that FunC's dead code elimination is quirky. |
Sorry, my bad. We just had a debugging session with @i582 and turns out the issues is the code dict internal structure is changed because of the changing method_ids |
|
🐗 |
Issue
Closes #2767.
Checklist
docs/and made the build locally