Skip to content

Conversation

@novusnota
Copy link
Member

@novusnota novusnota commented Apr 14, 2025

Issue

Closes #2767.

Checklist

  • I have updated CHANGELOG.md
  • I have documented my contribution in docs/ and made the build locally
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases

@novusnota novusnota added this to the v1.6.6 milestone Apr 14, 2025
@novusnota novusnota marked this pull request as ready for review April 14, 2025 21:40
@novusnota novusnota requested a review from a team as a code owner April 14, 2025 21:40
Copy link
Contributor

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's not change the FunC benchmarks in this PR

@novusnota
Copy link
Member Author

novusnota commented Apr 15, 2025

let's not change the FunC benchmarks in this PR

The FunC benchmarks do not use the sha256() in any way, but they're compiled with stdlib.fc and stdlib_ex.fc that Tact use and that somehow affects them. I've opened a separate issue for that #2776.

If I revert the changes to benchmarked JSONs then CI won't pass :)

UPD: Looking for the source of trouble. As @anton-trunov pointed out, the reason might be that FunC's dead code elimination is quirky.

@anton-trunov
Copy link
Contributor

UPD: Looking for the source of trouble. As @anton-trunov pointed out, the reason might be that FunC's dead code elimination is quirky.

Sorry, my bad. We just had a debugging session with @i582 and turns out the issues is the code dict internal structure is changed because of the changing method_ids

@Shvandre
Copy link
Contributor

🐗

Shvandre
Shvandre previously approved these changes Apr 15, 2025
@novusnota novusnota requested a review from Shvandre April 15, 2025 21:48
@anton-trunov anton-trunov merged commit 17345c2 into main Apr 16, 2025
25 checks passed
@anton-trunov anton-trunov deleted the closes-2767 branch April 16, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimize onchain logic of sha256() and introduce the keccak256() function

5 participants