feat: enhance contract testing environment #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulyadav-57
force-pushed
the
feat/improve-contract-testing
branch
from
ef49a2d to
213ee16
Compare
Contributor
|
Double message about completed setup |
Contributor
|
Safari has infinity loading. I know, we doesn't support Safari for tests, but can we hide this loader? 
|
Contributor
|
Only worried about the points above, no other worries |
Contributor
Author
|
I'll add a check for safari. |
rahulyadav-57
force-pushed
the
feat/improve-contract-testing
branch
from
213ee16 to
9e40c63
Compare
Contributor
|
Now, it's OK. |
Contributor
|
Conflicts |
verytactical
suggested changes
Mar 28, 2025
Contributor
verytactical
left a comment
verytactical
left a comment
There was a problem hiding this comment.
User agent strings are meant to be checked on backend, where there is no other information about browser capabilities.
It must not ever be checked on frontend.
Contributor
👍 |
verytactical
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #149
Resolves #249