Skip to content

fix: Unescape all existing HTML entities #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2020
Merged

fix: Unescape all existing HTML entities #239

merged 1 commit into from
Oct 31, 2020

Conversation

@untitaker
Copy link
Contributor

@untitaker untitaker commented Oct 28, 2020

Fix #238

@untitaker untitaker mentioned this pull request Oct 28, 2020
Closed
@untitaker
Copy link
Contributor Author

untitaker commented Oct 28, 2020

I can't reliably run rustfmt on this codebase without reformatting everything.

@tafia
Copy link
Owner

tafia commented Oct 31, 2020

That's awesome thanks!
Merging it but I'm wondering if it wouldn't be better to use some HashMap now that the list is so big.

@tafia tafia merged commit 8155c4b into tafia:master Oct 31, 2020
@untitaker untitaker deleted the fix/unescape-all-html-entities branch November 5, 2020 22:11
@tafia
Copy link
Owner

tafia commented Feb 5, 2021

Following issue #255 this will now be behind a 'escape-html' feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Is this crate aiming to parse HTML?

2 participants

@untitaker @tafia