-
Notifications
You must be signed in to change notification settings - Fork 266
Add zero-copy deserialization #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Is there interest in this? |
|
I expect there is, he's just been inactive for a few weeks (not a criticism) |
|
Sorry for the long delay in answering. I have reviewed it and I am not sure I understand it all so I didn't want to merge too quickly ... then life happened. I'll to it this week |
Co-authored-by: Sergio Benitez <sb@sergio.bz>
|
Alright after far too many months, I have finally reviewed this PR. Thanks SO MUCH for this work, there is not much to say. I have rebased it on current master and made tiny cosmetic modifications. |
|
I'll probably make a new version very soon in case you're still interested. |
|
To be fair, it looks like the Github CI is broken, silently. As in the jobs failed (to run) without any warning on the PR, just a green check mark that said "no conflicts". That's a huge UX issue on the part of Github, and I think the problems (the compilation failure at the very least) would have been pretty obvious if not for that. @tafia Thank you for spending some time to get things reviewed and merged |
This effectively rebases #208 on the current tip and fixes up some, but certainly not all, of the issues I spotted along the way. The
html5test is not passing (I'm not sure why it expects bad utf-8?) and neither are the tests that were previously commented out which I assume means they weren't passing then, either.I'd love to see this merged. I won't have futher time myself to continue working on this, but I thought I'd nudge it in the right direction. I've given @andreivasiliu commit access to the fork and the owners of this repository have access as well. Feel free to work in the fork or take this work and fork it itself and PR - whatever. Also don't feel the need to maintain my authorship of this PR in any way. Please do quite literally whatever you wish with this.